Merge pull request #785 from Shopify/test-helper-should-throw

`check` test helper shouldn't silently swallow errors

Author: six-shopify

packages/theme-check-common/src/test/test-helper.ts

@@ -39,16 +39,19 @@ export function getTheme(themeDesc: MockTheme): Theme {
 
 export async function check(
   themeDesc: MockTheme,
-  checks: CheckDefinition<SourceCodeType>[] = recommended,
+  checks: CheckDefinition[] = recommended,
   mockDependencies: Partial<Dependencies> = {},
   checkSettings: ChecksSettings = {},
 ): Promise<Offense[]> {
   const theme = getTheme(themeDesc);
   const config: Config = {
     context: 'theme',
     settings: { ...checkSettings },
-    checks: checks,
+    checks,
     rootUri,
+    onError: (err) => {
+      throw err;
+    },
   };
 
   const sections = new Map(