Remove 'CaptureOnContentForBlock' check (#1050)

* Remove 'CaptureOnContentForBlock' check

* Update .changeset/curvy-teachers-enjoy.md

Author: karreiro

.changeset/curvy-teachers-enjoy.md

@@ -0,0 +1,6 @@
+---
+'@shopify/theme-check-common': minor
+'@shopify/theme-check-node': minor
+---
+
+Remove 'CaptureOnContentForBlock' check — Theme development standards have evolved and changed, and this check has been fully deactivated on major themes. With more intense use blocks, this technique proven as a good approach to avoid duplication and promote reusability

packages/theme-check-common/src/checks/capture-on-content-for-block/index.spec.ts

@@ -7,7 +7,6 @@ import { AssetSizeAppBlockJavaScript } from './asset-size-app-block-javascript';
 import { AssetSizeCSS } from './asset-size-css';
 import { AssetSizeJavaScript } from './asset-size-javascript';
 import { BlockIdUsage } from './block-id-usage';
-import { CaptureOnContentForBlock } from './capture-on-content-for-block';
 import { CdnPreconnect } from './cdn-preconnect';
 import { ContentForHeaderModification } from './content-for-header-modification';
 import { DeprecateBgsizes } from './deprecate-bgsizes';
@@ -75,7 +74,6 @@ export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   AssetSizeCSS,
   AssetSizeJavaScript,
   BlockIdUsage,
-  CaptureOnContentForBlock,
   CdnPreconnect,
   ContentForHeaderModification,
   DeprecateBgsizes,

packages/theme-check-common/src/checks/capture-on-content-for-block/index.ts

@@ -31,9 +31,6 @@ AssetSizeJavaScript:
 BlockIdUsage:
   enabled: true
   severity: 1
-CaptureOnContentForBlock:
-  enabled: true
-  severity: 0
 CdnPreconnect:
   enabled: true
   severity: 0

packages/theme-check-common/src/checks/index.ts

@@ -9,9 +9,6 @@ AssetPreload:
 BlockIdUsage:
   enabled: true
   severity: 1
-CaptureOnContentForBlock:
-  enabled: true
-  severity: 0
 CdnPreconnect:
   enabled: true
   severity: 0