Skip to content

Conversation

@Ladicek
Copy link

@Ladicek Ladicek commented Jun 7, 2021

Co-authored-by: Jim Kleine [email protected]

Fixes #205

Co-authored-by: Jim Kleine <[email protected]>
@ghost ghost added the cla-needed label Jun 7, 2021
@miry
Copy link
Contributor

miry commented Aug 27, 2021

Hi @Ladicek

thank you for the contribution.
I changed a bit a releasing part.

Now there is Goreleaser.
The configuration for linux packages specified in https://goreleaser.com/customization/nfpm/

Here is an example: https://github.com/Shopify/toxiproxy/blob/master/.goreleaser.yml#L63

Is it possible to disable running service by default?

@Ladicek
Copy link
Author

Ladicek commented Aug 27, 2021

Sorry, I don't really know, I'm no systemd expert :-)

@Ladicek Ladicek closed this Aug 27, 2021
@Ladicek Ladicek deleted the systemd-unit-file branch August 27, 2021 09:48
@jimkleine
Copy link

Hi @miry

If you can clarify your intent, I can take a look at this (I provided the original sample systemd service file), as there has just been another report of the service failing with an error on Ubuntu 24.04.

I think you are:

  1. Proposing a PR to install the systemd service via .goreleaser.yml; and

  2. Asking that the service be disabled by default. I might question if this is a reasonable user expectation? If yes, this implies that the documentation may also need to be updated.

Have I understood you correctly?

I don't often work with Go, so I will need a couple of days to get up to speed with Goreleaser.

Hi @Ladicek

thank you for the contribution.
I changed a bit a releasing part.

Now there is Goreleaser.
The configuration for linux packages specified in https://goreleaser.com/customization/nfpm/

Here is an example: https://github.com/Shopify/toxiproxy/blob/master/.goreleaser.yml#L63

Is it possible to disable running service by default?

@miry
Copy link
Contributor

miry commented Dec 18, 2025

Proposing a PR to install the systemd service via .goreleaser.yml

yes

@jimkleine
Copy link

@miry Do you have current thoughts about my part two: whether the service should be installed in a disabled state?

Proposing a PR to install the systemd service via .goreleaser.yml

yes

@miry
Copy link
Contributor

miry commented Dec 18, 2025

Asking that the service be disabled by default. I might question if this is a reasonable user expectation? If yes, this implies that the documentation may also need to be updated.

As far as I know, most packages I have used on Fedora require users to configure the desired behavior themselves.

@jimkleine
Copy link

@miry Thanks for your feedback. Your reference to Fedora led me to this guidance on default service starts. Toxiproxy might meet test #4 if it only listens on localhost by default.

I had been thinking about this through a developer lens, but there is a wider security implication to consider.

Asking that the service be disabled by default. I might question if this is a reasonable user expectation? If yes, this implies that the documentation may also need to be updated.

As far as I know, most packages I have used on Fedora require users to configure the desired behavior themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit toxiproxy.service not found

3 participants