Skip to content

Commit 4aeed9f

Browse files
authored
remove temp steps (#3689)
1 parent 60470b9 commit 4aeed9f

File tree

1 file changed

+2
-25
lines changed

1 file changed

+2
-25
lines changed

.github/workflows/deploy.yml

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
name: Deploy
22

33
on:
4-
workflow_dispatch: # temporary for manual deployment
54
push:
65
branches:
76
# Stable version branches
@@ -46,35 +45,13 @@ jobs:
4645
NPM_TOKEN: '' # Forces OIDC authentication
4746
GITHUB_TOKEN: ${{ secrets.SHOPIFY_GH_ACCESS_TOKEN }}
4847

49-
- name: Temporary manual sync 'latest' tag # will be removed after sync
50-
if: github.event_name == 'workflow_dispatch' && github.ref_name == vars.LATEST_STABLE_VERSION
51-
env:
52-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
53-
run: |
54-
# dist-tag does not support OIDC yet, so fallback to classic token
55-
# overwrite the .npmrc to ensure no OIDC session conflicts
56-
echo "---Overwriting $NPM_CONFIG_USERCONFIG ---"
57-
echo "@shopify:registry=https://registry.npmjs.org/" > "$NPM_CONFIG_USERCONFIG"
58-
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" >> "$NPM_CONFIG_USERCONFIG"
59-
60-
# Debug info
61-
echo "--- npm identity check ---"
62-
npm whoami --registry=https://registry.npmjs.org/
63-
64-
# Run with info logging
65-
npm dist-tag add @shopify/[email protected] latest --loglevel=info
66-
48+
# Known to fail in OIDC (https://github.com/npm/cli/issues/8547).
49+
# Workaround is to manually ask #help-eng-infrastructure to update `latest` tag.
6750
- name: Set 'latest' NPM dist tag
6851
if: steps.changesets.outputs.published == 'true' && github.ref_name == vars.LATEST_STABLE_VERSION
6952
env:
7053
PUBLISHED_PACKAGES: ${{ steps.changesets.outputs.publishedPackages }}
71-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
7254
run: |
73-
# dist-tag does not support OIDC yet, so fallback to classic token
74-
# overwrite the .npmrc to ensure no OIDC session conflicts
75-
echo "@shopify:registry=https://registry.npmjs.org/" > "$NPM_CONFIG_USERCONFIG"
76-
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" >> "$NPM_CONFIG_USERCONFIG"
77-
7855
for pkg in $(echo "$PUBLISHED_PACKAGES" | jq -r '.[] | @base64'); do
7956
_jq() {
8057
echo ${pkg} | base64 --decode | jq -r ${1}

0 commit comments

Comments
 (0)