Skip to content

Commit 5a9fa29

Browse files
committed
removed some warnings on the examples
1 parent 2e0b730 commit 5a9fa29

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

packages/ui-extensions/src/surfaces/admin/components/Popover/examples/table-display-options.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<s-stack gap="small-200">
88
<s-stack gap="small">
99
<s-heading>Choose columns to display</s-heading>
10-
<s-choice-list>
10+
<s-choice-list label="Select columns to display">
1111
<s-choice value="sku" selected>Sku</s-choice>
1212
<s-choice value="inventory" selected>Inventory</s-choice>
1313
<s-choice value="price" selected>Price</s-choice>

packages/ui-extensions/src/surfaces/admin/components/Popover/examples/table-display-options.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<s-stack gap="small-200">
1313
<s-stack gap="small">
1414
<s-heading>Choose columns to display</s-heading>
15-
<s-choice-list>
15+
<s-choice-list label="Select columns to display">
1616
<s-choice value="sku" selected>
1717
Sku
1818
</s-choice>

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/indexTable.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@
22
<s-table>
33
<s-grid slot="filters" gap="small-200" gridTemplateColumns="1fr auto">
44
<s-text-field
5+
label="Search puzzles"
6+
labelAccessibilityVisibility="exclusive"
57
icon="search"
68
placeholder="Searching all puzzles"
79
></s-text-field>
810
<s-button
911
icon="sort"
1012
variant="secondary"
13+
accessibilityLabel="Sort"
1114
interestFor="sort-tooltip"
1215
commandFor="sort-actions"
1316
></s-button>

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/indexTable.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@
22
<s-table>
33
<s-grid slot="filters" gap="small-200" gridTemplateColumns="1fr auto">
44
<s-text-field
5+
label="Search puzzles"
6+
labelAccessibilityVisibility="exclusive"
57
icon="search"
68
placeholder="Searching all puzzles"
79
/>
810
<s-button
911
icon="sort"
1012
variant="secondary"
13+
accessibilityLabel="Sort"
1114
interestFor="sort-tooltip"
1215
commandFor="sort-actions"
1316
/>

0 commit comments

Comments
 (0)