Fix RenderExtension interface to support synchronous renders and make the clean up function optional

vividviolet · vividviolet · commit 63040f6ef114 · 2024-11-18T16:02:37.000-05:00
diff --git a/packages/ui-extensions/src/surfaces/admin/registration.ts b/packages/ui-extensions/src/surfaces/admin/registration.ts
@@ -1,5 +1,7 @@
 export interface RenderExtension<Api> {
-  (root: HTMLElement, api: Api): Promise<void | (() => void)>;
+  (root: HTMLElement, api: Api):
+    | (void | (() => void))
+    | Promise<void | (() => void)>;
 }
 
 export interface ExtensionRegistrationFunction<ExtensionTargets> {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`export interface RenderExtension<Api> {`
`2`		`- (root: HTMLElement, api: Api): Promise<void \| (() => void)>;`
	`2`	`+ (root: HTMLElement, api: Api):`
	`3`	`+ \| (void \| (() => void))`
	`4`	`+ \| Promise<void \| (() => void)>;`
`3`	`5`	`}`
`4`	`6`
`5`	`7`	`export interface ExtensionRegistrationFunction<ExtensionTargets> {`