Skip to content

Commit 6d61309

Browse files
authored
Remove deprecation of min and max props in NumberField (#3030)
### Background Related to issue [#1999](shop/issues-retail#1999) ### Solution We are not deprecating min and max so I updated the docs. ### 🎩 - in ui-extension terminal, run `yarn docs:point-of-sale` - in shopify-dev, run `dev s` - Press ctrl + T to view in browser. Navigate to https://shopify-dev.myshopify.io/docs/api/pos-ui-extensions/unstable/components/numberfield ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/aQSCLikeEHKP71ewIlF3/d1c7feac-0e7a-4792-8653-9038363866f5.png) ### Checklist - [x] I have 🎩'd these changes - [x] I have updated relevant documentation
2 parents 99a8de6 + 45443ba commit 6d61309

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.changeset/famous-badgers-dance.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/ui-extensions': patch
3+
---
4+
5+
NumberField - remove deprecation of min and max props

packages/ui-extensions/src/surfaces/point-of-sale/render/components/NumberField/NumberField.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import type {InputProps} from '../shared/InputField';
99
export interface NumberFieldProps extends InputProps {
1010
inputMode?: 'decimal' | 'numeric';
1111
/**
12-
* @deprecated Implement validation logic instead. This prop will be removed in 2025-10.
12+
* The highest decimal or integer to be accepted for the field.
1313
*/
1414
max?: number;
1515
/**
16-
* @deprecated Implement validation logic instead. This prop will be removed in 2025-10.
16+
* The lowest decimal or integer to be accepted for the field.
1717
*/
1818
min?: number;
1919
}

0 commit comments

Comments
 (0)