Skip to content

Commit 71760bb

Browse files
authored
Merge pull request #2646 from Shopify/remove-cash-tracking-cancel-event
Remove "pos.cash-tracking-session-cancel.event.observe" event target
2 parents 8c59e3f + 4704dfd commit 71760bb

File tree

9 files changed

+2
-49
lines changed

9 files changed

+2
-49
lines changed

.changeset/funny-walls-flash.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@shopify/ui-extensions': minor
33
---
44

5-
Add "pos.cash-tracking-session-start.event.observe", "pos.cash-tracking-session-cancel.event.observe", and "pos.cash-tracking-session-complete.event.observe" and renamed "pos.transaction-completed.event.observe".
5+
Add "pos.cash-tracking-session-start.event.observe" and "pos.cash-tracking-session-complete.event.observe" and renamed "pos.transaction-completed.event.observe".

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cash-tracking-session-cancel.event.observe.doc.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cash-tracking-session-complete.event.observe.doc.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ const data: ReferenceEntityTemplateSchema = {
99
subCategory: 'Cash tracking',
1010
isVisualComponent: false,
1111
related: [
12-
{
13-
name: ExtensionTargetType.PosCashTrackingSessionCancelObserve,
14-
url: '/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-cancel-observe',
15-
},
1612
{
1713
name: ExtensionTargetType.PosCashTrackingSessionStartObserve,
1814
url: '/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-start-observe',

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cash-tracking-session-start.event.observe.doc.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ const data: ReferenceEntityTemplateSchema = {
99
subCategory: 'Cash tracking',
1010
isVisualComponent: false,
1111
related: [
12-
{
13-
name: ExtensionTargetType.PosCashTrackingSessionCancelObserve,
14-
url: '/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-cancel-observe',
15-
},
1612
{
1713
name: ExtensionTargetType.PosCashTrackingSessionCompleteObserve,
1814
url: '/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-complete-observe',

packages/ui-extensions/docs/surfaces/point-of-sale/reference/types/ExtensionTargetType.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export enum ExtensionTargetType {
1818
PosDraftOrderDetailsBlockRender = 'pos.draft-order-details.block.render',
1919
PosTransactionCompleteObserve = 'pos.transaction-complete.event.observe',
2020
PosCashTrackingSessionStartObserve = 'pos.cash-tracking-session-start.event.observe',
21-
PosCashTrackingSessionCancelObserve = 'pos.cash-tracking-session-cancel.event.observe',
2221
PosCashTrackingSessionCompleteObserve = 'pos.cash-tracking-session-complete.event.observe',
2322
PosCartUpdateObserve = 'pos.cart-update.event.observe',
2423
PosReceiptFooterBlockRender = 'pos.receipt-footer.block.render',
@@ -44,7 +43,6 @@ export enum TargetLink {
4443
PosDraftOrderDetailsBlockRender = '[pos.draft-order-details.block.render](/docs/api/pos-ui-extensions/targets/draft-order-details/pos-draft-order-details-block-render)',
4544
PosTransactionCompleteObserve = '[pos.transaction-complete.event.observe](/docs/api/pos-ui-extensions/targets/post-purchase/pos-transaction-complete-observe)',
4645
PosCashTrackingSessionStartObserve = '[pos.cash-tracking-session-start.event.observe](/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-start-observe)',
47-
PosCashTrackingSessionCancelObserve = '[pos.cash-tracking-session-cancel.event.observe](/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-cancel-observe)',
4846
PosCashTrackingSessionCompleteObserve = '[pos.cash-tracking-session-complete.event.observe](/docs/api/pos-ui-extensions/targets/cash-tracking/pos-cash-tracking-session-complete-observe)',
4947
PosCartUpdateObserve = '[pos.cart-update.event.observe](/docs/api/pos-ui-extensions/targets/cart-update-observe)',
5048
PosReceiptFooterBlockRender = '[pos.receipt-footer.block.render](/docs/api/pos-ui-extensions/targets/receipts/pos-receipt-footer-block-render)',

packages/ui-extensions/docs/surfaces/point-of-sale/staticPages/pages/versions.doc.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Refer to the [migration guide](/docs/api/pos-ui-extensions/migrating) for more i
4949
### Features
5050
5151
- Added support for the ${TargetLink.PosTransactionCompleteObserve} target.
52-
- Added support for cash tracking session. ${TargetLink.PosCashTrackingSessionStartObserve}, ${TargetLink.PosCashTrackingSessionCancelObserve}, ${TargetLink.PosCashTrackingSessionCompleteObserve} targets.
52+
- Added support for cash tracking session. ${TargetLink.PosCashTrackingSessionStartObserve}, ${TargetLink.PosCashTrackingSessionCompleteObserve} targets.
5353
- Added support for the ${TargetLink.PosReceiptFooterBlockRender} target.
5454
- Introduced a [POSReceiptBlock component](/docs/api/pos-ui-extensions/components/posreceiptblock). It's the required parent component for ${TargetLink.PosReceiptFooterBlockRender} targets.
5555
`,

packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,3 @@ export interface CashTrackingSessionCompleteInput extends BaseInput {
1414
closingTime: string;
1515
};
1616
}
17-
18-
export interface CashTrackingSessionCancelInput extends BaseInput {
19-
cashTrackingSessionCancel: {
20-
id: number;
21-
openingTime?: string;
22-
closingTime?: string;
23-
};
24-
}

packages/ui-extensions/src/surfaces/point-of-sale/event/targets.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {BaseIntent} from '../intent';
22
import {
33
CashTrackingSessionStartInput,
44
CashTrackingSessionCompleteInput,
5-
CashTrackingSessionCancelInput,
65
} from './input/CashTrackingSessionInput';
76
import {TransactionCompleteInput} from './input/TransactionCompleteInput';
87
import {CartUpdateEventInput} from './input/CartUpdateEventInput';
@@ -14,9 +13,6 @@ export interface EventExtensionTargets {
1413
'pos.cash-tracking-session-start.event.observe': (
1514
input: CashTrackingSessionStartInput,
1615
) => BaseIntent;
17-
'pos.cash-tracking-session-cancel.event.observe': (
18-
input: CashTrackingSessionCancelInput,
19-
) => BaseIntent;
2016
'pos.cash-tracking-session-complete.event.observe': (
2117
input: CashTrackingSessionCompleteInput,
2218
) => BaseIntent;

packages/ui-extensions/src/surfaces/point-of-sale/input.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ export type {BaseInput} from './event/input/BaseInput';
22
export type {TransactionCompleteInput} from './event/input/TransactionCompleteInput';
33
export type {
44
CashTrackingSessionCompleteInput,
5-
CashTrackingSessionCancelInput,
65
CashTrackingSessionStartInput,
76
} from './event/input/CashTrackingSessionInput';
87

0 commit comments

Comments
 (0)