Skip to content

Commit f66ae59

Browse files
authored
Remove Cart Line Item Details block render target (#2987)
### Background This removes the Cart Line Item Details Block Render target, as we are not moving that to stable. A [documentation PR is here](https://github.com/Shopify/shopify-dev/pull/58963). ### Solution (Describe your solution, why this approach was chosen, and what the alternatives/impacts may be) ### 🎩 - ... ### Checklist - [ ] I have 🎩'd these changes - [ ] I have updated relevant documentation
2 parents 5b5768c + 568ef8e commit f66ae59

File tree

10 files changed

+21
-110
lines changed

10 files changed

+21
-110
lines changed

.changeset/grumpy-walls-sell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/ui-extensions': minor
3+
---
4+
5+
Remove Cart Line Item Details Block Render target

packages/ui-extensions/docs/surfaces/point-of-sale/reference/apis/cart-line-item-api.doc.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ The Cart Line Item API provides an extension with data about the current Cart Li
1313
#### Supporting targets
1414
- ${TargetLink.PosCartLineItemDetailsActionMenuItemRender}
1515
- ${TargetLink.PosCartLineItemDetailsActionRender}
16-
- ${TargetLink.PosCartLineItemDetailsBlockRender}
1716
`,
1817
isVisualComponent: false,
1918
type: 'APIs',
@@ -45,10 +44,6 @@ The Cart Line Item API provides an extension with data about the current Cart Li
4544
name: ExtensionTargetType.PosCartLineItemDetailsActionRender,
4645
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-action-render',
4746
},
48-
{
49-
name: ExtensionTargetType.PosCartLineItemDetailsBlockRender,
50-
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-block-render',
51-
},
5247
],
5348
};
5449

packages/ui-extensions/docs/surfaces/point-of-sale/reference/examples/targets/pos-cart-line-item-details-block-render.ts

Lines changed: 0 additions & 31 deletions
This file was deleted.

packages/ui-extensions/docs/surfaces/point-of-sale/reference/examples/targets/pos-cart-line-item-details-block-render.tsx

Lines changed: 0 additions & 25 deletions
This file was deleted.

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cart-line-item-details-action-menu-item-render.doc.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ const data: ReferenceEntityTemplateSchema = {
2121
name: ExtensionTargetType.PosCartLineItemDetailsActionRender,
2222
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-action-render',
2323
},
24-
{
25-
name: ExtensionTargetType.PosCartLineItemDetailsBlockRender,
26-
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-block-render',
27-
},
2824
],
2925
type: 'Target',
3026
};

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cart-line-item-details-action-render.doc.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ const data: ReferenceEntityTemplateSchema = {
2121
name: ExtensionTargetType.PosCartLineItemDetailsActionMenuItemRender,
2222
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-action-menu-item-render',
2323
},
24-
{
25-
name: ExtensionTargetType.PosCartLineItemDetailsBlockRender,
26-
url: '/docs/api/pos-ui-extensions/targets/pos-cart-line-item-details-block-render',
27-
},
2824
],
2925
type: 'Target',
3026
};

packages/ui-extensions/docs/surfaces/point-of-sale/reference/targets/pos.cart-line-item-details-block-render.doc.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

packages/ui-extensions/docs/surfaces/point-of-sale/reference/types/ExtensionTargetType.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export enum ExtensionTargetType {
2323
PosReceiptFooterBlockRender = 'pos.receipt-footer.block.render',
2424
PosCartLineItemDetailsActionMenuItemRender = 'pos.cart.line-item-details.action.menu-item.render',
2525
PosCartLineItemDetailsActionRender = 'pos.cart.line-item-details.action.render',
26-
PosCartLineItemDetailsBlockRender = 'pos.cart.line-item-details.block.render',
2726
}
2827

2928
export enum TargetLink {
@@ -51,5 +50,4 @@ export enum TargetLink {
5150
PosReceiptFooterBlockRender = '[pos.receipt-footer.block.render](/docs/api/pos-ui-extensions/targets/receipts/pos-receipt-footer-block-render)',
5251
PosCartLineItemDetailsActionMenuItemRender = '[pos.cart.line-item-details.action.menu-item.render](/docs/api/pos-ui-extensions/targets/cart-details/pos-cart-line-item-details-action-menu-item-render)',
5352
PosCartLineItemDetailsActionRender = '[pos.cart.line-item-details.action.render](/docs/api/pos-ui-extensions/targets/cart-details/pos-cart-line-item-details-action-render)',
54-
PosCartLineItemDetailsBlockRender = '[pos.cart.line-item-details.block.render](/docs/api/pos-ui-extensions/targets/cart-details/pos-cart-line-item-details-block-render)',
5553
}

packages/ui-extensions/docs/surfaces/point-of-sale/staticPages/pages/extension-targets.doc.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,22 @@ Review [all extension targets](/docs/api/pos-ui-extensions/targets).
194194
description: `
195195
Renders a custom section within the native draft order details screen.
196196
197+
Review [all extension targets](/docs/api/pos-ui-extensions/targets).
198+
`,
199+
},
200+
],
201+
},
202+
{
203+
type: 'GenericAccordion',
204+
title: 'Cart line item details',
205+
anchorLink: 'cart-line-item-details',
206+
sectionContent: 'The cart line item details screen',
207+
accordionContent: [
208+
{
209+
title: 'Action',
210+
description: `
211+
Displays an action target in the cart line item details screen.
212+
197213
Review [all extension targets](/docs/api/pos-ui-extensions/targets).
198214
`,
199215
},

packages/ui-extensions/src/surfaces/point-of-sale/targets.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -152,13 +152,6 @@ export interface ExtensionTargets {
152152
CartLineItemApi,
153153
BasicComponents
154154
>;
155-
'pos.cart.line-item-details.block.render': RenderExtension<
156-
StandardApi<'pos.cart.line-item-details.block.render'> &
157-
ActionApi &
158-
CartApi &
159-
CartLineItemApi,
160-
BlockComponents
161-
>;
162155
'pos.receipt-footer.block.render': RenderExtension<
163156
// NOTE: key/any type is cause of no arg useApi() that includes all target types.
164157
// stop using useApi() with no args, instead specify the target type explicitly.

0 commit comments

Comments
 (0)