-
Notifications
You must be signed in to change notification settings - Fork 53
Add OIDC to rc branch #3650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC to rc branch #3650
Conversation
279363c to
528e491
Compare
Update
|
528e491 to
1b896ee
Compare
.github/workflows/deploy.yml
Outdated
| - id: changesets | ||
| name: Create release Pull Request or publish to NPM | ||
| uses: changesets/action@06245a4e0a36c064a573d4150030f5ec548e4fcc # v1.4.10 | ||
| uses: changesets/action@v1 # Must use latest version for OIDC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy-chhuon do you know what version added support for OIDC or is pinning it to a commit hash not compatible with OIDC? It would be good to keep pinned to a specific version so we don't automatically opt-into new versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @andy-chhuon ! Surprisingly the intro image does have a pinned version. Could you ping the team that owns the page about the discrepancy and ask them to update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah interesting, will do!
b4029cd to
01fb914
Compare


Background
Migrate from npm to OIDC according to docs to avoid 404 error
Also see, #3650 (comment)