Add EmptyState docs #3661
Merged
Add EmptyState docs #3661
+82
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cappslock
requested review from
BrittaEvansFenton,
armaan-ghosh and
prakashraman
Contributor
|
Did you mean to add the Tab stuff in here too? There is just no mention of it in the description. Please either remove or add into Descriptions |
Contributor
Author
|
@BrittaEvansFenton it's generated output that's true to the source, so no, not intentional, but would also require just spinning up a second PR with those changes, which would block this PR. I'd honestly rather just get them in at once given the timeframe we're dealing with. |
Contributor
|
Absolutely, just edit the description so at least when we go back to figure out what we did later we have some context 😅 |
BrittaEvansFenton
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EmptyState docs. Partially resolves https://github.com/shop/issues-retail/issues/21717.
This includes some unrelated changes to tab due to upstream changes in the definition file. It's safer to commit these than ignore them.