Skip to content

Action fails on "new-ish" macOS releases #19

@MichalSalon

Description

@MichalSalon

Hi,

this action fails on new-ish (latest 3) MacOS releases due to outdated dependencies.

My issue is specifically caused by old version of macos-release lib: https://github.com/Shopify/upload-to-release/blob/master/node_modules/macos-release/index.js failing for macos-latest:

2024-02-28T14:20:04.7511480Z ##[group]Run Shopify/upload-to-release@c77c9b3e5d288adaef98a7007bf92340ec6ce03b
2024-02-28T14:20:04.7512380Z with:
2024-02-28T14:20:04.7513430Z   name: XYZ-darwin-arm64
2024-02-28T14:20:04.7513920Z   path: ./bin/XYZ-darwin-arm64
2024-02-28T14:20:04.7514710Z   repo-token: ***
2024-02-28T14:20:04.7515170Z   content-type: application/octet-stream
2024-02-28T14:20:04.7515710Z ##[endgroup]
2024-02-28T14:20:05.0146320Z /Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/universal-user-agent/index.js:13
2024-02-28T14:20:05.0149100Z     throw error
2024-02-28T14:20:05.0170380Z     ^
2024-02-28T14:20:05.0174120Z 
2024-02-28T14:20:05.0177240Z TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
2024-02-28T14:20:05.0181100Z     at macosRelease (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/macos-release/index.js:26:26)
2024-02-28T14:20:05.0185340Z     at osName (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/os-name/index.js:21:18)
2024-02-28T14:20:05.0189820Z     at getUserAgentNode (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/universal-user-agent/index.js:7:53)
2024-02-28T14:20:05.0194270Z     at Object.<anonymous> (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/@octokit/graphql/index.js:5:52)
2024-02-28T14:20:05.0197680Z     at Module._compile (node:internal/modules/cjs/loader:1198:14)
2024-02-28T14:20:05.0200160Z     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
2024-02-28T14:20:05.0202720Z     at Module.load (node:internal/modules/cjs/loader:1076:32)
2024-02-28T14:20:05.0205180Z     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
2024-02-28T14:20:05.0209890Z     at Module.require (node:internal/modules/cjs/loader:1100:19)
2024-02-28T14:20:05.0213310Z     at require (node:internal/modules/cjs/helpers:119:18)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions