Merge pull request #354 from Shopify/update-regex-and-require-postcodes-in-MT

Require postcodes and update regex in MT

Author: rochlefebvre

CHANGELOG.md

@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Security in case of vulnerabilities.
 
 ## [Unreleased]
+- Require postcodes and update regex in MT [#354](https://github.com/Shopify/worldwide/pull/354)
 
 ---
 

data/regions/MT.yml

@@ -9,11 +9,10 @@ tax_inclusive: true
 group: European Countries
 group_name: Europe
 phone_number_prefix: 356
-zip_regex: "^(MT?-?)?[ABĊCDEFĠGHĦIJKLMNOPQRSTUVWXYŻZ]{2,3}( ?\\d{2,4})?$"
-zip_requirement: recommended
+zip_regex: "^(MT-?)?([Tt][Pp]|[A-Za-z]{3}) ?[0-9]{4}$"
 tags:
 - EU-member
-zip_example: NXR 01
+zip_example: VLT 1933
 format:
   edit: "{country}_{firstName}{lastName}_{company}_{address1}_{address2}_{city}{zip}_{phone}"
   show: "{firstName} {lastName}_{company}_{address1}_{address2}_{city} {zip}_{country}_{phone}"

test/worldwide/regions/mt_test.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module Worldwide
+  class MtTest < ActiveSupport::TestCase
+    setup do
+      @region = Worldwide.region(code: "MT")
+    end
+
+    test "zip codes with country prefix are valid" do
+      assert @region.valid_zip?("MT-VLT 1933")
+      assert @region.valid_zip?("MT-VLT1933")
+    end
+
+    test "zip codes without country prefix are valid" do
+      assert @region.valid_zip?("VLT 1933")
+      assert @region.valid_zip?("VLT1933")
+    end
+
+    test "two-letter zip codes from Tigné Point are valid" do
+      assert @region.valid_zip?("TP 1933")
+      assert @region.valid_zip?("TP1933")
+    end
+
+    test "other two-letter zip codes are invalid" do
+      assert_not @region.valid_zip?("AA 1933")
+    end
+
+    test "pre-2007 formatted zip codes are invalid" do
+      assert_not @region.valid_zip?("VLT 05")
+    end
+
+    test "malformed zip codes are invalid" do
+      assert_not @region.valid_zip?("VLT 193")
+      assert_not @region.valid_zip?("VLT 19333")
+    end
+  end
+end