Skip to content

Commit 1c529c5

Browse files
ShreyaLaxminarayangiritrivedi
authored andcommitted
- Avoid referencing ILAsm/ILDAsm packages in servicing releases, since they aren't published.
- CoreCLR shippable packages were unblocked from being published in servicing releases after PR: dotnet/runtime#113020 - Fixed versioning mismatches in dotnet-10 releases. Signed-off-by: shreya <[email protected]>
1 parent 3826623 commit 1c529c5

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

dotnet-build

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,10 @@ function build_runtime {
9999
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.DotNetHostPolicy.$runtime_version.nupkg" "$OUTPUTDIR"
100100
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.DotNetHostResolver.$runtime_version.nupkg" "$OUTPUTDIR"
101101
fi
102-
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.ILAsm.$runtime_version.nupkg" "$OUTPUTDIR"
103-
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.ILDAsm.$runtime_version.nupkg" "$OUTPUTDIR"
102+
if [ "$(grep -oP '<PreReleaseVersionLabel>\K[^<]+' eng/Versions.props)" != "servicing" ] || git merge-base --is-ancestor bb5f473 HEAD; then
103+
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.ILAsm.$runtime_version.nupkg" "$OUTPUTDIR"
104+
cp "artifacts/packages/$runtime_conf/Shipping/runtime.linux-$ARCH.Microsoft.NETCore.ILDAsm.$runtime_version.nupkg" "$OUTPUTDIR"
105+
fi
104106
if [ "$ARCH" = s390x ]; then
105107
tar -C artifacts/obj/mono/[Ll]inux."$ARCH"."$runtime_conf"/out/lib -czf "$OUTPUTDIR"/libmono-profiler-log-"$ARCH".tar.gz libmono-profiler-log.so
106108
fi
@@ -192,8 +194,14 @@ function build_sdk {
192194
if git merge-base --is-ancestor 5a42929 HEAD; then
193195
sdk_build_flags+=("/p:MicrosoftAspNetCoreAppRefPackageVersion=$aspnetcore_version"
194196
"/p:MicrosoftNETCoreAppRefPackageVersion=$runtime_version"
195-
"/p:MicrosoftAspNetCoreAppRefInternalPackageVersion=$aspnetcore_internal_version"
196-
"/p:MicrosoftNETCorePlatformsPackageVersion=$runtime_version")
197+
"/p:MicrosoftAspNetCoreAppRefInternalPackageVersion=$aspnetcore_internal_version")
198+
else
199+
sdk_build_flags+=("/p:MicrosoftNETCoreAppRuntimewinx64PackageVersion=$runtime_version"
200+
"/p:MicrosoftNETCoreAppHostwinx64PackageVersion=$runtime_version"
201+
"/p:MicrosoftAspNetCoreAppRuntimewinx64PackageVersion=$aspnetcore_version")
202+
fi
203+
if [ "$runtime_major_version" -gt 9 ]; then
204+
sdk_build_flags+=("/p:MicrosoftNETCorePlatformsPackageVersion=$runtime_version")
197205
fi
198206
if [ -z ${SKIP_BUILD_SDK+x} ] && [ ! -e .skip-build ]; then
199207
./build.sh "${sdk_build_flags[@]}"
@@ -237,10 +245,11 @@ function build_aspnetcore {
237245
fi
238246
pushd aspnetcore
239247
if [ "$runtime_major_version" -gt 9 ]; then
240-
aspnetcore_build_flags+=("/p:MicrosoftNETCoreAppRefVersion=$runtime_version")
241-
242-
else
243-
aspnetcore_build_flags+=("/p:MicrosoftNETCoreAppRuntimeVersion=$runtime_version")
248+
if git merge-base --is-ancestor c23abd6 HEAD; then
249+
aspnetcore_build_flags+=("/p:MicrosoftNETCoreAppRefVersion=$runtime_version")
250+
else
251+
aspnetcore_build_flags+=("/p:MicrosoftNETCoreAppRuntimeVersion=$runtime_version")
252+
fi
244253
fi
245254

246255
if [ -z ${SKIP_BUILD_ASPNETCORE+x} ] && [ ! -e .skip-build ]; then

0 commit comments

Comments
 (0)