Skip to content

Conversation

@Shuangcheng-Ni
Copy link
Owner

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

As we discussed on gitter, some extra insert-mode key bindings might dismiss the finder buffer. For example, if a user has something like inoremap <BS> <C-r>=auto_pair()<CR> in his/her .vimrc, the finder buffer would immediately disappear after pressing <BS>.
This commit fixes the problem. It tries to override all the global mappings with some buffer-local mappings that remap each previously mapped key sequence to itself in the finder buffer, while the previously defined buffer-local mappings in the finder buffer are not overridden.

[Please explain in detail why the changes in this PR are needed.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants