Further optimized usecase generation a tiny bit

Author: frikky

db-connector.go

@@ -1698,11 +1698,15 @@ func Fixexecution(ctx context.Context, workflowExecution WorkflowExecution) (Wor
 	dbsave := false
 	workflowExecution.Workflow.Image = ""
 
-	if workflowExecution.Status != "EXECUTING" {
-		validation, err := GetExecutionValidation(ctx, workflowExecution.ExecutionId)
-		if err == nil {
-			workflowExecution.Workflow.Validation = validation
+	// FIXME: May be a problem here with setting it at all times~ 
+	//if workflowExecution.Status != "EXECUTING" {
+	validation, err := GetExecutionValidation(ctx, workflowExecution.ExecutionId)
+	if err == nil {
+		if workflowExecution.NotificationsCreated > 0 {
+			validation.NotificationsCreated = workflowExecution.NotificationsCreated
 		}
+
+		workflowExecution.Workflow.Validation = validation
 	}
 
 	// Make sure to not having missing items in the execution
@@ -3235,6 +3239,15 @@ func GetWorkflow(ctx context.Context, id string) (*Workflow, error) {
 			cacheData := []byte(cache.([]uint8))
 			err = json.Unmarshal(cacheData, &workflow)
 			if err == nil && workflow.ID != "" {
+				validationData, err := GetCache(ctx, fmt.Sprintf("validation_workflow_%s", workflow.ID))
+				if err == nil {
+					cacheData := []byte(validationData.([]uint8))
+					err = json.Unmarshal(cacheData, &workflow.Validation)
+					if err != nil {
+						log.Printf("[ERROR] Failed unmarshalling cache data for execution status (4): %s", err)
+					}
+				}
+
 				// Somehow this can happen. Reverting to LATEST revision
 				if len(workflow.Actions) > 0 && len(workflow.Triggers) == 0 {
 					revisions, err := ListWorkflowRevisions(ctx, workflow.ID, 2)

shared.go

@@ -5016,6 +5016,9 @@ func HandleGetTriggers(resp http.ResponseWriter, request *http.Request) {
 }
 
 func GetGcpSchedule(ctx context.Context, id string) (*ScheduleOld, error) {
+	if project.Environment != "cloud" {
+		return &ScheduleOld{}, nil
+	}
 
 	// Check if we have the schedule in cache
 	cacheData, err := GetCache(ctx, fmt.Sprintf("schedule-%s", id))
@@ -5055,9 +5058,13 @@ func GetGcpSchedule(ctx context.Context, id string) (*ScheduleOld, error) {
 	}
 	resp, err := c.GetJob(ctx, req)
 	if err != nil {
-		log.Printf("[ERROR] Failed getting schedule %s: %s", id, err)
+		if !strings.Contains(err.Error(), "NotFound") {
+			log.Printf("[ERROR] Failed getting schedule %s: %s", id, err)
+		}
+
 		return schedule, err
 	}
+
 	schedule.Id = id
 	schedule.Name = resp.Name
 	if resp.State == schedulerpb.Job_ENABLED {
@@ -10587,7 +10594,7 @@ func GetSpecificWorkflow(resp http.ResponseWriter, request *http.Request) {
 	}
 
 	//Check if workflow trigger schedule is in sync with the gcp cron job
-	if workflow.Triggers != nil {
+	if project.Environment == "cloud" && workflow.Triggers != nil {
 		var wg sync.WaitGroup
 		triggerMutex := sync.Mutex{}
 
@@ -23299,7 +23306,7 @@ func HealthCheckHandler(resp http.ResponseWriter, request *http.Request) {
 // 2. Parent workflow's owner is same org?
 // 3. Parent execution auth is correct
 func RunExecuteAccessValidation(request *http.Request, workflow *Workflow) (bool, string) {
-	log.Printf("[DEBUG] Inside execute validation for workflow %s (%s)! Request method: %s", workflow.Name, workflow.ID, request.Method)
+	//log.Printf("[DEBUG] Inside execute validation for workflow %s (%s)! Request method: %s", workflow.Name, workflow.ID, request.Method)
 
 	//if request.Method == "POST" {
 	ctx := GetContext(request)
@@ -30585,6 +30592,7 @@ func checkExecutionStatus(ctx context.Context, exec *WorkflowExecution) *Workflo
 		*/
 	}
 
+	exec.Workflow.Validation.NotificationsCreated = exec.NotificationsCreated
 	exec.Workflow.Validation = workflow.Validation
 	marshalledValidation, err := json.Marshal(workflow.Validation)
 	if err != nil {
@@ -30597,7 +30605,6 @@ func checkExecutionStatus(ctx context.Context, exec *WorkflowExecution) *Workflo
 	SetCache(backgroundContext, cacheKey, marshalledValidation, 120)
 
 	// ALWAYS have correct exec id for current execution, but not always in workflow
-
 	//log.Printf("\n\n[DEBUG][%s] Set workflow validation (%d) to '%s'\n\n", exec.ExecutionId, len(workflow.Validation.Errors), marshalledValidation)
 
 	return exec

structs.go

@@ -1532,6 +1532,7 @@ type TypeValidation struct {
 	ChangedAt     int64 `json:"changed_at" datastore:"changed_at"`
 	LastValid     int64 `json:"last_valid" datastore:"last_valid"`
 	ValidationRan bool  `json:"validation_ran" datastore:"validation_ran"`
+	NotificationsCreated int64  `json:"notifications_created" datastore:"notifications_created"`
 
 	// For the last update, which did it
 	WorkflowId  string `json:"workflow_id" datastore:"workflow_id"`