fix: updates for lalit

Author: 0x0elliot

shared.go

@@ -6554,13 +6554,20 @@ func diffWorkflows(oldWorkflow Workflow, parentWorkflow Workflow, update bool) {
 			}
 		}
 
+		
+		for _, trigger := range childWorkflow.Triggers {
+
+
 		if len(addedTriggers) > 0 {
+			log.Printf("[DEBUG] Triggers added: %d", len(addedTriggers))
 			triggers := childTriggers
 			for _, trigger := range parentWorkflow.Triggers {
 				if !ArrayContains(addedTriggers, trigger.ID) {
 					continue
 				}
 
+				log.Printf("[DEBUG] ID of the added trigger: %s", trigger.ID)
+
 				triggers = append(triggers, trigger)
 			}
 
@@ -6583,7 +6590,9 @@ func diffWorkflows(oldWorkflow Workflow, parentWorkflow Workflow, update bool) {
 		}
 
 		if len(updatedTriggers) > 0 {
+			log.Printf("[DEBUG] Triggers updated: %d", len(updatedTriggers))
 			for _, action := range updatedTriggers {
+				log.Printf("[DEBUG] ID of the updated trigger: %s", action.ID)
 				for index, childAction := range childWorkflow.Triggers {
 					if childAction.ID != action.ID {
 						continue
@@ -6795,6 +6804,22 @@ func diffWorkflows(oldWorkflow Workflow, parentWorkflow Workflow, update bool) {
 			}
 		}
 
+		// Old childWorkflow triggers:
+		for _, oldTrigger := range oldWorkflow.Triggers {
+			// params
+			for _, param := range oldTrigger.Parameters {
+				log.Printf("[DEBUG] Old trigger %s (%s) has param %s and value: %s", oldTrigger.Label, oldTrigger.ID, param.Name, param.Value)
+			}
+		}
+
+		// to be updated triggers
+		for _, trigger := range newTriggers {
+			// params
+			for _, param := range trigger.Parameters {
+				log.Printf("[DEBUG] New trigger %s (%s) has param %s and value: %s", trigger.Label, trigger.ID, param.Name, param.Value)
+			}
+		}
+
 		childWorkflow.Actions = newActions
 		childWorkflow.Triggers = newTriggers
 		childWorkflow.Branches = newBranches
@@ -9652,6 +9677,8 @@ func GenerateWorkflowFromParent(ctx context.Context, workflow Workflow, parentOr
 		// E.g. for webhooks, how do we have a URL correctly, and start/stop properly?
 		newWf.Triggers[triggerIndex].Status = "uninitialized"
 		if newWf.Triggers[triggerIndex].TriggerType == "WEBHOOK" {
+			oldID := newWf.Triggers[triggerIndex].ID
+			newWf.Triggers[triggerIndex].ID = uuid.NewV4().String()
 			for paramIndex, param := range newWf.Triggers[triggerIndex].Parameters {
 				if param.Name == "url" {
 					newWf.Triggers[triggerIndex].Parameters[paramIndex].Value = ""
@@ -9660,6 +9687,19 @@ func GenerateWorkflowFromParent(ctx context.Context, workflow Workflow, parentOr
 				if param.Name == "tmp" {
 					newWf.Triggers[triggerIndex].Parameters[paramIndex].Value = ""
 				}
+
+				newWf.Triggers[triggerIndex].ReplacementForTrigger = oldID
+
+				// edit all branch source ids where the ID is changed
+				for branchIndex, branch := range newWf.Branches {
+					if branch.SourceID == oldID {
+						newWf.Branches[branchIndex].SourceID = newWf.Triggers[triggerIndex].ID
+					}
+
+					if branch.DestinationID == oldID {
+						newWf.Branches[branchIndex].DestinationID = newWf.Triggers[triggerIndex].ID
+					}
+				}
 			}
 		}
 	}

structs.go

@@ -1206,8 +1206,9 @@ type Trigger struct {
 	SourceWorkflow string      `json:"source_workflow" yaml:"source_workflow" datastore:"source_workflow"`
 	ExecutionDelay int64       `json:"execution_delay" yaml:"execution_delay" datastore:"execution_delay"`
 	AppAssociation WorkflowApp `json:"app_association" yaml:"app_association" datastore:"app_association"`
-
 	ParentControlled bool `json:"parent_controlled" datastore:"parent_controlled"` // If the parent workflow node exists, and shouldn't be editable by child workflow
+
+	ReplacementForTrigger string `json:"replacement_for_trigger" datastore:"replacement_for_trigger"` // If this trigger is a replacement for another trigger
 }
 
 type Branch struct {