fix: Byte arrays represented as Anyvalue::Byte instead of string (open-telemetry#2807)

Author: cijothomas

opentelemetry-appender-tracing/CHANGELOG.md

@@ -46,7 +46,8 @@ transparent to most users.
 when conversion is feasible. Otherwise stored as
 `opentelemetry::logs::AnyValue::String`. This avoids unnecessary string
 allocation when values can be represented in their original types.
-
+- Byte arrays are stored as `opentelemetry::logs::AnyValue::Bytes` instead
+of string.
 - perf - small perf improvement by avoiding string allocation of `target`
 
 ## 0.28.1

opentelemetry-appender-tracing/src/layer.rs

@@ -80,6 +80,11 @@ impl<LR: LogRecord> tracing::field::Visit for EventVisitor<'_, LR> {
         }
     }
 
+    fn record_bytes(&mut self, field: &tracing_core::Field, value: &[u8]) {
+        self.log_record
+            .add_attribute(Key::new(field.name()), AnyValue::from(value));
+    }
+
     fn record_str(&mut self, field: &tracing_core::Field, value: &str) {
         #[cfg(feature = "experimental_metadata_attributes")]
         if is_duplicated_metadata(field.name()) {
@@ -350,7 +355,7 @@ mod tests {
         let big_u64value: u64 = u64::MAX;
         let small_usizevalue: usize = 42;
         let big_usizevalue: usize = usize::MAX;
-        error!(name: "my-event-name", target: "my-system", event_id = 20, small_u64value, big_u64value, small_usizevalue, big_usizevalue, user_name = "otel", user_email = "[email protected]");
+        error!(name: "my-event-name", target: "my-system", event_id = 20, bytes = &b"abc"[..], small_u64value, big_u64value, small_usizevalue, big_usizevalue, user_name = "otel", user_email = "[email protected]");
         assert!(logger_provider.force_flush().is_ok());
 
         // Assert TODO: move to helper methods
@@ -381,9 +386,9 @@ mod tests {
 
         // Validate attributes
         #[cfg(not(feature = "experimental_metadata_attributes"))]
-        assert_eq!(log.record.attributes_iter().count(), 7);
+        assert_eq!(log.record.attributes_iter().count(), 8);
         #[cfg(feature = "experimental_metadata_attributes")]
-        assert_eq!(log.record.attributes_iter().count(), 11);
+        assert_eq!(log.record.attributes_iter().count(), 12);
         assert!(attributes_contains(
             &log.record,
             &Key::new("event_id"),
@@ -419,6 +424,11 @@ mod tests {
             &Key::new("big_usizevalue"),
             &AnyValue::String(format!("{}", u64::MAX).into())
         ));
+        assert!(attributes_contains(
+            &log.record,
+            &Key::new("bytes"),
+            &AnyValue::Bytes(Box::new(b"abc".to_vec()))
+        ));
         #[cfg(feature = "experimental_metadata_attributes")]
         {
             assert!(attributes_contains(

opentelemetry/src/logs/record.rs

@@ -115,6 +115,12 @@ impl_trivial_from!(StringValue, AnyValue::String);
 
 impl_trivial_from!(bool, AnyValue::Boolean);
 
+impl From<&[u8]> for AnyValue {
+    fn from(val: &[u8]) -> AnyValue {
+        AnyValue::Bytes(Box::new(val.to_vec()))
+    }
+}
+
 impl<T: Into<AnyValue>> FromIterator<T> for AnyValue {
     /// Creates an [`AnyValue::ListAny`] value from a sequence of `Into<AnyValue>` values.
     fn from_iter<I: IntoIterator<Item = T>>(iter: I) -> Self {