-Wshift-count-overflow warnings when building on PPC

[barracuda156]

It still builds successfully, and even tests pass fine. But maybe these could be addressed?

/opt/local/bin/g++-mp-12 -std=gnu++17 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/opt/local/Library/Frameworks/R.framework/Versions/4.3/Resources/library/Rcpp/include' -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc  -c RcppExports.cpp -o RcppExports.o
/opt/local/bin/g++-mp-12 -std=gnu++17 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/opt/local/Library/Frameworks/R.framework/Versions/4.3/Resources/library/Rcpp/include' -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc  -c main.cpp -o main.o
In file included from main.cpp:2:
../inst/include/jagger.cc: In member function 'void jagger::tagger::read_model(const std::string&)':
../inst/include/jagger.cc:106:45: warning: left shift count >= width of type [-Wshift-count-overflow]
  106 |         fs2pid.insert (std::make_pair ((1ul << 32) | 2, fs2pid.size ()));
      |                                         ~~~~^~~~~
../inst/include/jagger.cc:107:30: warning: left shift count >= width of type [-Wshift-count-overflow]
  107 |         p2f_.push_back ((1ul << 32) | 2);
      |                          ~~~~^~~~~
../inst/include/jagger.cc:143:50: warning: left shift count >= width of type [-Wshift-count-overflow]
  143 |             = fs2pid.insert (std::make_pair ((fi << 32) | fi_, fs2pid.size ()));
      |                                               ~~~^~~~~
../inst/include/jagger.cc:144:47: warning: left shift count >= width of type [-Wshift-count-overflow]
  144 |           if (itb.second) p2f_.push_back ((fi << 32) | fi_);
      |                                            ~~~^~~~~
../inst/include/jagger.cc:168:51: warning: left shift count >= width of type [-Wshift-count-overflow]
  168 |           p2f_[i] = (offsets[(p2f_[i] >> 32) - 1] << 34) |
/opt/local/bin/g++-mp-12 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/opt/local/Library/Frameworks/R.framework/Resources/lib -Wl,-headerpad_max_install_names -Wl,-rpath,/opt/local/lib/libgcc -L/opt/local/lib -lMacportsLegacySupport -arch ppc -o RcppJagger.so RcppExports.o main.o -F/opt/local/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
installing to /opt/local/var/macports/build/_opt_PPCRosettaPorts_R_R-RcppJagger/R-RcppJagger/work/RcppJagger/RcppJagger.Rcheck/00LOCK-RcppJagger/00new/RcppJagger/libs

[Shusei-E]

Hi, thanks for the heads up! At least on my computer (macOS 12.6), I didn't get the warning. Would you be able to provide additional details (e.g., OS)? Your help is greatly appreciated.

> devtools::install()
Running /Library/Frameworks/R.framework/Resources/bin/R CMD INSTALL \
  /var/folders/hw/nwvjkgn10x3351tkvfg34t740000gn/T//RtmpwnxzeD/RcppJagger_0.0.1.tar.gz \
  --install-tests
* installing to library ‘/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library’
* installing *source* package ‘RcppJagger’ ...
** using staged installation
** libs
using C++ compiler: ‘Homebrew clang version 16.0.5’
using C++17
using SDK: ‘MacOSX13.1.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library/Rcpp/include' -I/opt/homebrew/opt/gettext/include -I/opt/homebrew/opt/llvm/include    -fPIC  -falign-functions=64 -Wall -g -O2  -c RcppExports.cpp -o RcppExports.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library/Rcpp/include' -I/opt/homebrew/opt/gettext/include -I/opt/homebrew/opt/llvm/include    -fPIC  -falign-functions=64 -Wall -g -O2  -c main.cpp -o main.o
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/homebrew/opt/gettext/lib -L/opt/homebrew/opt/llvm/lib -Wl,-rpath,/opt/homebrew/opt/llvm/lib -o RcppJagger.so RcppExports.o main.o -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -undefined dynamic_lookup may not work with chained fixups
installing to /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library/00LOCK-RcppJagger/00new/RcppJagger/libs
** R
** data
*** moving datasets to lazyload DB
** inst
** tests
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** checking absolute paths in shared objects and dynamic libraries
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (RcppJagger)

[barracuda156]

@Shusei-E Thank you for responding!

I think this has to do with 32-bitness, not with a compiler, OS or architecture family. (I build on macOS 10.6 for ppc with GCC 12.)

[Shusei-E]

Thanks! /inst/include/jagger.cc comes from the original Jagger (this package provides wrapper functions), so let me see what I can do.

[barracuda156]

@Shusei-E Hi, any update on this one? The issue still relevant with newer R and gcc:

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_R_R-RcppJagger/R-RcppJagger/work/RcppJagger" && /opt/local/bin/R CMD INSTALL . --library=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_R_R-RcppJagger/R-RcppJagger/work/build --install-tests 
* installing *source* package ‘RcppJagger’ ...
** package ‘RcppJagger’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘g++-mp-13 (MacPorts gcc13 13.2.0_4+stdlib_flag) 13.2.0’
using C++17
Warning in system2("xcrun", "--show-sdk-path", TRUE, TRUE) :
  running command ''xcrun' --show-sdk-path 2>&1' had status 64
using SDK: ‘NA’‘NA’‘NA’‘NA’‘NA’‘NA’
/opt/local/bin/g++-mp-13 -std=gnu++17 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/opt/local/Library/Frameworks/R.framework/Versions/4.4/Resources/library/Rcpp/include' -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc   -c RcppExports.cpp -o RcppExports.o
/opt/local/bin/g++-mp-13 -std=gnu++17 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/opt/local/Library/Frameworks/R.framework/Versions/4.4/Resources/library/Rcpp/include' -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc   -c main.cpp -o main.o
In file included from main.cpp:2:
../inst/include/jagger.cc: In member function 'void jagger::tagger::read_model(const std::string&)':
../inst/include/jagger.cc:106:45: warning: left shift count >= width of type [-Wshift-count-overflow]
  106 |         fs2pid.insert (std::make_pair ((1ul << 32) | 2, fs2pid.size ()));
      |                                         ~~~~^~~~~
../inst/include/jagger.cc:107:30: warning: left shift count >= width of type [-Wshift-count-overflow]
  107 |         p2f_.push_back ((1ul << 32) | 2);
      |                          ~~~~^~~~~
../inst/include/jagger.cc:143:50: warning: left shift count >= width of type [-Wshift-count-overflow]
  143 |             = fs2pid.insert (std::make_pair ((fi << 32) | fi_, fs2pid.size ()));
      |                                               ~~~^~~~~
../inst/include/jagger.cc:144:47: warning: left shift count >= width of type [-Wshift-count-overflow]
  144 |           if (itb.second) p2f_.push_back ((fi << 32) | fi_);
      |                                            ~~~^~~~~
../inst/include/jagger.cc:168:51: warning: left shift count >= width of type [-Wshift-count-overflow]
  168 |           p2f_[i] = (offsets[(p2f_[i] >> 32) - 1] << 34) |
/opt/local/bin/g++-mp-13 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/opt/local/Library/Frameworks/R.framework/Resources/lib -Wl,-headerpad_max_install_names -L/opt/local/lib -lMacportsLegacySupport -Wl,-rpath,/opt/local/lib/libgcc -arch ppc -o RcppJagger.so RcppExports.o main.o -F/opt/local/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
installing to /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_R_R-RcppJagger/R-RcppJagger/work/build/00LOCK-RcppJagger/00new/RcppJagger/libs
** R
** data
*** moving datasets to lazyload DB
** inst
** tests
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** checking absolute paths in shared objects and dynamic libraries
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (RcppJagger)

[Shusei-E]

Hi @barracuda156, thanks for the follow-up. Is this issue causing any practical problems on your end? To be honest, I'm a little stuck on this, as I couldn't replicate the warning in my environment. If you have an idea for the pull request, I'm more than happy to put it on CRAN.