Fix return key behavior, remove revoke warning, and make frontmost app when necessary

Author: lonkelle

AltServer/AppDelegate.swift

@@ -122,7 +122,6 @@ private extension AppDelegate
 
     @objc func sideloadIPA(to device: ALTDevice)
     {
-        NSRunningApplication.current.activate(options: .activateIgnoringOtherApps)
 
         let openPanel = NSOpenPanel()
         openPanel.canChooseDirectories = false
@@ -132,6 +131,7 @@ private extension AppDelegate
             guard let fileURL = openPanel.url, response == .OK else { return }
             self.installApplication(at: fileURL, to: device)
         }
+        NSRunningApplication.current.activate(options: .activateIgnoringOtherApps)
     }
 
     func enableJIT(for app: InstalledApp, on device: ALTDevice)
@@ -329,7 +329,7 @@ private extension AppDelegate {
 			logInMenuItem.action = #selector(logoutFromAppleID)
 		} catch {
 			print("Error getting stored AppleID credentials: \(error)")
-			logInMenuItem.title = "Save Apple ID to Keychain..."
+			logInMenuItem.title = "Save New Apple ID to Keychain..."
 			logInMenuItem.action = #selector(loginToAppleID)
 		}
 	}
@@ -441,6 +441,7 @@ extension AppDelegate: NSMenuDelegate
 
     func menuDidClose(_ menu: NSMenu)
     {
+        NSRunningApplication.current.activate(options: .activateIgnoringOtherApps)
         guard menu == self.appMenu else { return }
 
         // Clearing _jitAppListMenuControllers now prevents action handler from being called.

AltServer/Devices/ALTDeviceManager+Installation.swift

@@ -360,7 +360,7 @@ private extension ALTDeviceManager
 
                 // Check if there is another AltStore certificate, which means AltStore has been installed with this Apple ID before.
                 let altstoreCertificate = certificates.first { $0.machineName?.starts(with: "AltStore") == true }
-                if let previousCertificate = altstoreCertificate
+                /*if let previousCertificate = altstoreCertificate
                 {
                     if FileManager.default.fileExists(atPath: certificateFileURL.path),
                        let data = try? Data(contentsOf: certificateFileURL),
@@ -389,7 +389,7 @@ private extension ALTDeviceManager
                     }
 
                     guard !isCancelled else { return completionHandler(.failure(InstallError.cancelled)) }
-                }
+                }*/
 
                 func addCertificate()
                 {

AltServer/Views/AppleIDAuthenticationAlert.swift

@@ -53,16 +53,17 @@ final class AppleIDAuthenticationAlert: NSAlert {
 
 		window.initialFirstResponder = appleIDTextField
 
-		addButton(withTitle: NSLocalizedString("Cancel", comment: ""))
 		addButton(withTitle: NSLocalizedString("Continue", comment: ""))
+		addButton(withTitle: NSLocalizedString("Cancel", comment: ""))
 
 		validateTextFields()
 	}
 
 	/// Displays the alert modally, and returns a `Bool` saying whether the user did press "Continue".
 	func display() -> Bool {
 		let result = runModal()
-		return result == .alertSecondButtonReturn
+		NSRunningApplication.current.activate(options: .activateIgnoringOtherApps)
+		return result == .alertFirstButtonReturn
 	}
 }
 
@@ -80,6 +81,6 @@ private extension AppleIDAuthenticationAlert {
 	func validateTextFields() {
 		let isAppleIDTextFieldValid = !appleIDValue.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty
 		let isPasswordTextFieldValid = !passwordValue.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty
-		buttons.last?.isEnabled = isAppleIDTextFieldValid && isPasswordTextFieldValid
+		buttons.first?.isEnabled = isAppleIDTextFieldValid && isPasswordTextFieldValid
 	}
 }