Skip to content

chore: lazy load footer icons#2899

Merged
manika-signoz merged 1 commit intomainfrom
chore/footer-lazy
Mar 13, 2026
Merged

chore: lazy load footer icons#2899
manika-signoz merged 1 commit intomainfrom
chore/footer-lazy

Conversation

@manika-signoz
Copy link
Contributor

@manika-signoz manika-signoz commented Mar 13, 2026

Summary

replaces <img with Image from next in footer

Problem

footer images being preloaded
Screenshot 2026-03-13 at 20 14 24

Changes

Description

Type of Change

  • Docs – Changes to data/docs/**
  • Blog – Changes to data/blog/**
  • Site Code – Changes to app/**, components/**, hooks/**, utils/**, config, etc.
  • Redirects – Renamed/moved docs or updated next.config.js redirects
  • Dependencies / CI / Scripts
  • Other – Explain below

Impact

  • Documentation only
  • UI changes
  • Developer workflow
  • Performance impact
  • Breaking change

If breaking change, describe migration steps:

Context & Screenshots

Before / After (if applicable)

Checklist

General

  • Branch is up to date with main
  • PR title follows conventional format (type: description)
  • Self-reviewed the code
  • Comments added for complex logic

For all changes

  • Built locally (yarn build) with no errors
  • Ran yarn lint and fixed any issues
  • Pre-commit hooks passed (or ran yarn check:doc-redirects / yarn check:docs-metadata if applicable)

For docs changes (data/docs/**)

  • Completed the Docs PR Checklist in CONTRIBUTING.md
  • Added/updated the page in constants/docsSideNav.ts if adding or moving a doc

For blog changes

  • Frontmatter includes title, date, author, tags (and canonicalUrl if applicable)
  • Images use WebP format and live under public/img/blog/<YYYY-MM>/

For site code changes

  • Follows Site Code Guidelines in CONTRIBUTING.md
  • New dependencies are justified in the PR description (if any)

For renamed or moved docs

  • Added permanent redirect in next.config.js under async redirects()
  • Updated internal links and sidebar in constants/docsSideNav.ts
  • Ran yarn check:doc-redirects to verify

Testing

  • Tested locally
  • Edge cases considered
  • Existing functionality verified
  • New tests added (if applicable)

Steps to test:
1.
2.
3.

Rollout / Deployment Notes

Additional Context


Note: Submit as Draft by default. Mark "Ready for review" when checks pass and content is ready.

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
signoz-web Ready Ready Preview, Comment Mar 13, 2026 2:47pm

Request Review

@manika-signoz manika-signoz marked this pull request as ready for review March 13, 2026 14:38
@manika-signoz manika-signoz requested a review from a team as a code owner March 13, 2026 14:38
@claude
Copy link
Contributor

claude bot commented Mar 13, 2026

Claude finished @manika-signoz's task in 1m 6s —— View job


Review: PR #2899 — Lazy load footer icons

  • Gather context and read changed files
  • Review using frontend PR skill
  • Post review summary

Overall: Good change — converting <img> to Next.js <Image> for the HIPAA/SOC-2 icons and adding descriptive alt text are both improvements. A couple of items to address:

Medium

  • onClick + window.open on <Image> is not accessible (inline comment): The HIPAA and SOC-2 images use onClick={() => window.open(...)} for navigation. This is a pre-existing issue, but since the elements are being rewritten, it's a good time to wrap them in <Link> instead. The current approach is not keyboard-navigable and not announced as a link by screen readers.

Low

  • loading="lazy" is redundant on <Image> (inline comment): Next.js <Image> lazy-loads by default. The explicit loading="lazy" props on all three images are harmless but unnecessary.

No other issues found. The <img><Image> conversion, alt text additions, and PR scope are all clean.

@manika-signoz manika-signoz merged commit fad4fe5 into main Mar 13, 2026
8 checks passed
@manika-signoz manika-signoz deleted the chore/footer-lazy branch March 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants