Skip to content

Commit 130227b

Browse files
phantinussnasbench
andauthored
Merge PR #4581 from @phantinuss - Remove in changlog, additional attribution, workflow optimization, FP tuning
chore: run sigma rule repo tests only on specific paths chore: add manual thanks and list removed rules in changelog fix: Rundll32 Execution Without DLL File - remove command line restriction bc of numerous FPs --------- Co-authored-by: Nasreddine Bencherchali <8741929+nasbench@users.noreply.github.com>
1 parent e506e45 commit 130227b

File tree

4 files changed

+25
-23
lines changed

4 files changed

+25
-23
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Thanks for your contribution. Please make sure to fill the contents of this temp
88

99
<!--
1010
**Please note that this section is required and must be filled**
11-
A short summary of your pull request.
11+
A short summary of your pull request.
1212
-->
1313

1414
### Changelog
@@ -19,13 +19,15 @@ You need to add one line for every changed file of the PR and prefix one of the
1919
new: <title>
2020
update: <title> - <optional comment>
2121
fix: <title> - <optional comment>
22+
remove: <title> - <optional comment>
2223
chore: for non-detection related changes (e.g. dates/titles) and changes on workflow
2324
2425
e.g.
2526
new: Brute-Force Attacks on Azure Admin Account
2627
update: Suspicious Microsoft Office Child Process - add MSPUB.EXE
2728
fix: Malware User Agent - remove legitimate Firefox UA
2829
chore: workflow - update checkout version
30+
remove: Suspicious Office Execution - deprecated in favour of 8f922766-a1d3-4b57-9966-b27de37fddd2
2931
-->
3032

3133
### Example Log Event

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,13 @@ jobs:
2424
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*new: ' | sort | sed -e 's%^% - %' >> changes.txt
2525
if [[ $(git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*update: ' -c) -gt 0 ]]; then echo "### Updated Rules" >> changes.txt; fi
2626
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*update: ' | sort | sed -e 's%^% - %' >> changes.txt
27+
if [[ $(git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*remove: ' -c) -gt 0 ]]; then echo "### Removed / Deprecated Rules" >> changes.txt; fi
28+
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*remove: ' | sort | sed -e 's%^% - %' >> changes.txt
2729
if [[ $(git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*fix: ' -c) -gt 0 ]]; then echo "### Fixed Rules" >> changes.txt; fi
2830
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -E '^\s*fix: ' | sort | sed -e 's%^% - %' >> changes.txt
2931
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -ioP 'Merge PR #\d+ from \K(@\S+)' | sort -u > authors_raw.txt
3032
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -oP "Co-authored-by: \K.*(?= <)" | sort -u | sed -e 's%^%@%' >> authors_raw.txt
33+
git log --pretty=%B ${prev_tag}..${curr_tag} | grep -ioP "Thanks: \K.*" | sort -u >> authors_raw.txt
3134
LC_ALL=en_US.UTF-8 sort -u authors_raw.txt | grep -v 'dependabot\[bot\]' > authors.txt
3235
cat changes.txt >> changelog.txt
3336
echo "" >> changelog.txt

.github/workflows/sigma-test.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ on: # yamllint disable-line rule:truthy
77
push:
88
branches:
99
- "*"
10-
# paths:
11-
# - "deprecated/**.yml"
12-
# - "rules-compliance/**.yml"
13-
# - "rules-dfir/**.yml"
14-
# - "rules-emerging-threats/**.yml"
15-
# - "rules-placeholder/**.yml"
16-
# - "rules-threat-hunting/**.yml"
17-
# - "rules/**.yml"
18-
# - "unsupported/**.yml"
10+
paths:
11+
- "deprecated/**.yml"
12+
- "rules-compliance/**.yml"
13+
- "rules-dfir/**.yml"
14+
- "rules-emerging-threats/**.yml"
15+
- "rules-placeholder/**.yml"
16+
- "rules-threat-hunting/**.yml"
17+
- "rules/**.yml"
18+
- "unsupported/**.yml"
1919
pull_request:
2020
branches:
2121
- master
22-
# paths:
23-
# - "deprecated/**.yml"
24-
# - "rules-compliance/**.yml"
25-
# - "rules-dfir/**.yml"
26-
# - "rules-emerging-threats/**.yml"
27-
# - "rules-placeholder/**.yml"
28-
# - "rules-threat-hunting/**.yml"
29-
# - "rules/**.yml"
30-
# - "unsupported/**.yml"
22+
paths:
23+
- "deprecated/**.yml"
24+
- "rules-compliance/**.yml"
25+
- "rules-dfir/**.yml"
26+
- "rules-emerging-threats/**.yml"
27+
- "rules-placeholder/**.yml"
28+
- "rules-threat-hunting/**.yml"
29+
- "rules/**.yml"
30+
- "unsupported/**.yml"
3131

3232
# Allows you to run this workflow manually from the Actions tab
3333
workflow_dispatch:

rules/windows/process_creation/proc_creation_win_rundll32_executable_invalid_extension.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ references:
66
- https://twitter.com/mrd0x/status/1481630810495139841?s=12
77
author: Tim Shelton, Florian Roth (Nextron Systems), Yassine Oukessou (fix + fp)
88
date: 2022/01/13
9-
modified: 2023/10/11
9+
modified: 2023/11/14
1010
tags:
1111
- attack.defense_evasion
1212
- attack.t1218.011
@@ -51,9 +51,6 @@ detection:
5151
- 'C:\Windows\Installer\MSI'
5252
- '.tmp'
5353
- 'zzzzInvokeManagedCustomActionOutOfProc'
54-
CommandLine|contains:
55-
- 'Avira.OE.Setup'
56-
- 'FindOldJetBrainsProduct'
5754
condition: selection and not 1 of filter_*
5855
fields:
5956
- Image

0 commit comments

Comments
 (0)