Build warnings in 2.9.1

[adam-durridge]

While updating from 2.8.0 to 2.9.0 I ran into these two "assignment from incompatible pointer type [-Wincompatible-pointer-types]" warnings in rsi_wlan_apis.c:

wiseconnect-wifi-bt-sdk/sapi/wlan/rsi_wlan_apis.c

Line 7850 in c95f054

rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_data_receive_cb = callback_handler_ptr;

and

wiseconnect-wifi-bt-sdk/sapi/wlan/rsi_wlan_apis.c

Line 7856 in c95f054

rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_tx_data_status_cb = callback_handler_ptr;

Both lines are in uint16_t rsi_wlan_register_callbacks().

This function takes a callback handler pointer of this type as an argument:
void (*callback_handler_ptr)(uint16_t status, uint8_t *buffer, const uint32_t length))

The two callbacks in question have these prototypes:
void (*sl_wifi_btr_80211_data_receive_cb)(RSI_STATUS status, uint8_t *buffer, uint32_t length, int8_t rssi, uint32_t rate);

and

void (*sl_wifi_btr_80211_tx_data_status_cb)(uint16_t status, uint32_t token, uint8_t priority, uint32_t rate);

I'm not currently using this feature, however I'd like to get rid of the warnings without hacking it up too badly.

[adam-durridge]

I think the extra arguments could just be sent as the normal payload. It looks like they get set by reading into the payload using host_desc[] and reading beyond its 16 byte size:

wiseconnect-wifi-bt-sdk/sapi/driver/rsi_wlan.c

Lines 3062 to 3073 in c95f054

	if (rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_data_receive_cb != NULL) {
	rssi = host_desc[16];
	rate = host_desc[18];
	payload_offset = host_desc[4];
	// Call asynchronous Wi-Fi BTR 802.11 data receive handler to indicate to host
	rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_data_receive_cb(0,
	payload + payload_offset,
	payload_length - payload_offset,
	rssi,
	rate);
	} else if (rsi_wlan_cb_non_rom->callback_list.wlan_data_receive_handler != NULL) {

and

wiseconnect-wifi-bt-sdk/sapi/driver/rsi_wlan.c

Lines 2374 to 2386 in c95f054

	case SL_WIFI_BTR_TX_DATA_STATUS: {
	uint16_t status;
	uint32_t token, rate;
	uint8_t priority;
	status = host_desc[15];
	token = rsi_bytes4R_to_uint32(&host_desc[24]);
	rate = host_desc[16];
	priority = host_desc[20];
	if (rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_tx_data_status_cb != NULL) {
	// Call asynchronous response handler to indicate to host
	rsi_wlan_cb_non_rom->callback_list.sl_wifi_btr_80211_tx_data_status_cb(status, token, priority, rate);
	}
	} break;

wiseconnect-wifi-bt-sdk/sapi/include/rsi_pkt_mgmt.h

Lines 49 to 54 in c95f054

	// host descriptor
	uint8_t desc[16];
	// payload
	uint8_t data[1];
	} rsi_pkt_t;

[adam-durridge]

Still an issue in 2.9.1, updating title