|
1 | | -# Contributing Guideline - Internal Repository |
| 1 | +# Contributing Guideline |
| 2 | +As an open-source project, we welcome and encourage the community to submit patches directly to the project. |
| 3 | +In our collaborative open-source environment, standards and methods for submitting changes help reduce |
| 4 | +the chaos that can result from an active development community. |
| 5 | + |
| 6 | +This document explains how to participate in project conversations, log bugs and enhancement requests, |
| 7 | +and submit patches to the project so your patch will be accepted quickly into the codebase. |
| 8 | + |
| 9 | +## Prerequisites |
| 10 | +You should be familiar with Git and GitHub. [Getting started](https://docs.github.com/en/get-started) |
| 11 | +If you haven't already done so, you'll need to create a (free) GitHub account at https://github.com |
| 12 | +and have Git tools available on your development system. You also need to add your email address to your account. |
| 13 | + |
| 14 | +As a contributor, you'll want to be familiar with the Silicon Labs tooling: |
| 15 | +- [Simplicity Studio](https://docs.silabs.com/simplicity-studio-5-users-guide/latest/ss-5-users-guide-overview/) |
| 16 | +- [Platform](https://docs.silabs.com/gecko-platform/latest/platform-overview/) |
| 17 | +- [Simplicity Commander](https://docs.silabs.com/simplicity-commander/latest/simplicity-commander-start/) |
| 18 | + |
| 19 | +Read the Silicon Labs [coding guidelines](https://github.com/SiliconLabsSoftware/agreements-and-guidelines/blob/main/coding_standard.md). |
| 20 | +## Git Setup |
| 21 | +We need to know who you are, and how to contact you. Please ass the following information to your Git installation: |
| 22 | +``` |
| 23 | +git config --global user.name "FirstName LastName" |
| 24 | +git config --global user.email "[email protected]" |
| 25 | +``` |
| 26 | +set the Git configuration variables user.name to your full name, and user.email to your email address. |
| 27 | +The user.name must be your full name (first and last at minimum), not a pseudonym or hacker handle. |
| 28 | +The email address that you use in your Git configuration must match the email address you use to sign your commits. |
| 29 | + |
| 30 | +If you intend to edit commits using the Github.com UI, ensure that your github profile email address and profile name also match those used in your git configuration |
| 31 | +(user.name & user.email). |
2 | 32 |
|
3 | | -## Branch Naming Convention |
| 33 | +### Set up GitHub commit signature |
4 | 34 |
|
5 | | -Refer to the Developer Services Branching Policy and Git User [Guide](https://confluence.silabs.com/pages/viewpage.action?pageId=315870645). |
| 35 | +**command line setup** |
6 | 36 |
|
7 | | -Use lowercase letters and hyphens (`-`) as delimiters. |
8 | | -Google search treats a hyphen as a word separator, which helps improve the visibility of public repositories. |
9 | | -We should structure our internal repository as if it were a public one. |
| 37 | +The repository requires signed off commits. Follow this [guide](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) how to set it up. |
| 38 | +1. Generate a gpg key [howto](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key) |
| 39 | +2. Configure your local repository with the gpg key. [guide]whttps://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key) |
| 40 | +3. Configure your GitHub account with the gpg key [guide](https://docs.github.com/en/authentication/managing-commit-signature-verification/associating-an-email-with-your-gpg-key) |
10 | 41 |
|
11 | | -Branch name should be short and clear. If possible it can be the JIRA ticket name. |
12 | | -Also it is recommended to include the JIRA ticket number. |
13 | | -Example: |
| 42 | +**Command line steps:** |
| 43 | +Use the git-bash and navigate into your local repo. |
| 44 | +1. disable all the gpg signature globally. (Optional) |
| 45 | +``` |
| 46 | +$ git config --global --unset gpg.format |
| 47 | +``` |
| 48 | +2. Create a gpg-key |
| 49 | +``` |
| 50 | +$ gpg --full-generate-key |
| 51 | +``` |
| 52 | +3. Configure the local repo with your new key. |
| 53 | +``` |
| 54 | +$ gpg --list-secret-keys --keyid-format=long |
| 55 | +gpg: checking the trustdb |
| 56 | +gpg: marginals needed: 3 completes needed: 1 trust model: pgp |
| 57 | +gpg: depth: 0 valid: 1 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 1u |
| 58 | +/c/Users/silabsuser/.gnupg/pubring.kbx |
| 59 | +------------------------------------ |
| 60 | +sec rsa3072/1234567891234567 2025-04-09 [SC] |
| 61 | + ABDGDGFDGFDGDHHSRGRG12345667912345678981 |
| 62 | +uid [ultimate] Firstname Lastname <[email protected]> |
| 63 | +ssb rsa3072/11098765432110981 2025-04-09 [E] |
| 64 | +
|
| 65 | +$ git config user.signingkey 1234567891234567 |
| 66 | +``` |
| 67 | +4. Force every commit to be signed |
| 68 | +``` |
| 69 | +$ git config commit.gpgsign true |
| 70 | +``` |
| 71 | +5. Export your gpg key |
14 | 72 | ``` |
15 | | -IOT_DS-123-update-sdk-version |
| 73 | +$ gpg --armor --export 888BA795B7085898 |
16 | 74 | ``` |
| 75 | +Make sure your email address is verified by GitHub before committing anything. |
17 | 76 |
|
18 | | -## Commit Message Format |
| 77 | +## Licensing |
| 78 | +Please check the [Licensing.md](../LICENSE.md) for more details. |
19 | 79 |
|
20 | | -We use [smart commits](https://support.atlassian.com/bitbucket-cloud/docs/use-smart-commits/) to sync GitHub commits with our JIRA server. |
21 | | -This requires the JIRA ticket number in the commit message. |
22 | | -The first line is the commit message, and the next lines provide the description. |
23 | | -The commit message should be short and clear, and it must contain the JIRA ticket number. |
24 | | -You can add more details in the description. |
| 80 | +## Contributor License Agreement |
| 81 | +When a project receives a contribution, it must be clear that the contributor has the rights to contribute the content and that the project then has the rights to use and otherwise operate with the content (e.g., relicense or distribute). A Contributor License Agreement (CLA) is a legal document establishing these rights and defining the terms under which a license is granted by a contributor to an open-source project. A CLA clarifies that any contribution was authorized (not contributing someone else’s code without permission or without legal authority to contribute) and protects the project from potential future legal challenges. |
25 | 82 |
|
26 | | -**Command Line:** |
27 | | -``` |
28 | | -git commit -m "IOT_DS-1234 initial version of SDK 4.4.3 is committed" -m "Not final version. Several compiler warnings need to be addressed." |
29 | | -``` |
| 83 | +Please check Silicon Labs [CLA document](https://github.com/SiliconLabsSoftware/agreements-and-guidelines/blob/main/contributor_license_agreement.md). |
| 84 | +During the pull request review, every new contributor must sign the CLA document. It can be signed as an individual or on behalf of a company. |
| 85 | +Signatures have a 6-month expiration period. |
30 | 86 |
|
31 | | -**VS Code:** |
32 | | -The first line is the commit message, and the next lines are the commit description. |
| 87 | +## Contribution process |
| 88 | +### Creating an Issue |
| 89 | +Please follow the official GitHub [guide](https://opensource.guide/how-to-contribute/#opening-an-issue). |
33 | 90 |
|
34 | | -## Pull Request Guideline |
| 91 | +### Fork the repository |
| 92 | +When you created an issue and based on the discussion you want to contribute with your source-code. |
| 93 | +Branching is disabled on the public Silicon Labs repositories. You need to fork your own repo first. |
| 94 | +Please follow the official GitHub [guide](https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project). |
| 95 | +You can create your branch on your own forked repo now. |
35 | 96 |
|
36 | | -Refer to the general pull request [guideline](https://opensource.guide/how-to-contribute/#opening-a-pull-request) from GitHub. |
| 97 | +### Branch Naming Convention |
| 98 | +Branch naming shall follow the following template: *IssueNumber-issue-title-goes-here* |
| 99 | +Example branch name: |
| 100 | +``` |
| 101 | +99-bootloader-implementation |
| 102 | +``` |
| 103 | +Issue number is necessary to maintain tracebility. |
| 104 | +Now you have a branch. You can start committing your code onto it. |
37 | 105 |
|
38 | | -### As a Developer |
| 106 | +## Commit Messages |
39 | 107 |
|
40 | | -What to consider when raising a Pull Request: |
| 108 | +Silicon Labs repositories require signed-off commits. |
| 109 | +Every commit represents a change inside the repository. Every change needs to be documented extensively. |
| 110 | +``` |
| 111 | +Issuenumber-summary-of-changes |
41 | 112 |
|
42 | | -1. **Pull Request Naming** |
43 | | - By default, GitHub uses the branch name as the pull request title. If the branch naming guideline was followed, no changes are needed here. |
| 113 | +Detailed description what was implemented. |
| 114 | +Another line of really good description |
| 115 | +``` |
44 | 116 |
|
45 | | -2. **Check the Reviewer List** |
| 117 | +## Pull Request Guideline |
| 118 | +Okay you finished your work committed all your changes to your branch. Time to create a pull request. |
| 119 | +Refer to the general pull request [guideline](https://opensource.guide/how-to-contribute/#opening-a-pull-request) from GitHub. |
| 120 | +What to consider when raising a Pull Request: |
| 121 | +1. **Pull Request Naming** |
| 122 | + By default, GitHub uses the branch name as the pull request title. If the branch naming convention was followed, no changes are needed here. |
| 123 | +2. **Create Description** |
| 124 | + Fill out the pull request template. |
| 125 | +3. **Check the Reviewer List** |
46 | 126 | GitHub assigns reviewers based on the [CODEOWNERS](CODEOWNERS) file. |
47 | 127 | Add more reviewers if needed. Do not remove reviewers from the PR. Ask the repository owner for updates to the code owners. |
48 | | - |
49 | | -3. **Evaluate the Action Workflow Results** |
| 128 | +4. **Evaluate the Action Workflow Results** |
50 | 129 | The following workflows are included in every repository: |
51 | 130 | - **[Coding Convention Check](workflows/00-Check-Code-Convention.yml)**: Analyzes the code formatting and fails if any rules are broken. |
52 | 131 | - **[Firmware Build](workflows/02-Build-Firmware.yml)**: Builds the firmware inside the [Dockerfile](../Dockerfile). |
53 | 132 | - **[Secret Scanner](workflows/04-TruffleHog-Security-Scan.yml)**: Runs the TruffleHog security scanner to look for API keys and committed secrets. |
54 | | - - **[SonarQube Analysis](workflows/zz-sonarqube-analysis.yml)**: Runs SonarQube analysis on the project. Refer to the related [Confluence page](https://confluence.silabs.com/display/IoTApps/SQA+-+SonarQube+howTo). |
55 | 133 |
|
56 | 134 | ### As a Reviewer |
57 | 135 |
|
|
0 commit comments