[SL-ONLY] Adds check for power state change for invoking low-level power save APIs (#589)

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

Author: 3 people

src/platform/silabs/wifi/SiWx/WifiInterfaceImpl.cpp

@@ -460,6 +460,7 @@ sl_si91x_performance_profile_t ConvertPowerSaveConfiguration(PowerSaveInterface:
         profile = HIGH_PERFORMANCE;
         break;
     case PowerSaveInterface::PowerSaveConfiguration::kConnectedSleep:
+    case PowerSaveInterface::PowerSaveConfiguration::kLIConnectedSleep:
         profile = ASSOCIATED_POWER_SAVE;
         break;
     case PowerSaveInterface::PowerSaveConfiguration::kDeepSleep:
@@ -837,6 +838,9 @@ sl_status_t WifiInterfaceImpl::TriggerPlatformWifiDisconnection()
 #if CHIP_CONFIG_ENABLE_ICD_SERVER
 CHIP_ERROR WifiInterfaceImpl::ConfigurePowerSave(PowerSaveInterface::PowerSaveConfiguration configuration, uint32_t listenInterval)
 {
+    // Power save configuration is already set, nothing to do
+    VerifyOrReturnValue(mCurrentPowerSaveConfiguration != configuration, CHIP_NO_ERROR);
+
     int32_t error = rsi_bt_power_save_profile(RSI_SLEEP_MODE_2, RSI_MAX_PSP);
     VerifyOrReturnError(error == RSI_SUCCESS, CHIP_ERROR_INTERNAL,
                         ChipLogError(DeviceLayer, "rsi_bt_power_save_profile failed: %ld", error));
@@ -851,6 +855,7 @@ CHIP_ERROR WifiInterfaceImpl::ConfigurePowerSave(PowerSaveInterface::PowerSaveCo
     VerifyOrReturnError(status == SL_STATUS_OK, CHIP_ERROR_INTERNAL,
                         ChipLogError(DeviceLayer, "sl_wifi_set_performance_profile failed: 0x%lx", status));
 
+    mCurrentPowerSaveConfiguration = configuration;
     return CHIP_NO_ERROR;
 }
 

src/platform/silabs/wifi/icd/PowerSaveInterface.h

@@ -34,9 +34,10 @@ class PowerSaveInterface
 
     enum class PowerSaveConfiguration : uint8_t
     {
-        kHighPerformance = 0,
-        kDeepSleep       = 1,
-        kConnectedSleep  = 2,
+        kHighPerformance  = 0,
+        kDeepSleep        = 1,
+        kConnectedSleep   = 2,
+        kLIConnectedSleep = 3,
     };
 
     /**
@@ -66,6 +67,11 @@ class PowerSaveInterface
      *                                                         or if it is a non-supported configuration
      */
     virtual CHIP_ERROR ConfigureBroadcastFilter(bool enableBroadcastFilter) { return CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE; }
+
+protected:
+    // Default power save configuration is High Performance as the device starts in high power mode and low power modes need to be
+    // explicitly configured
+    PowerSaveConfiguration mCurrentPowerSaveConfiguration = PowerSaveConfiguration::kHighPerformance;
 };
 
 } // namespace Silabs

src/platform/silabs/wifi/icd/WifiSleepManager.cpp

@@ -162,7 +162,7 @@ CHIP_ERROR WifiSleepManager::ConfigureLIBasedSleep()
 
     // Allowing the device to go to sleep must be the last actions to avoid configuration failures.
     ReturnLogErrorOnFailure(
-        mPowerSaveInterface->ConfigurePowerSave(PowerSaveInterface::PowerSaveConfiguration::kConnectedSleep,
+        mPowerSaveInterface->ConfigurePowerSave(PowerSaveInterface::PowerSaveConfiguration::kLIConnectedSleep,
                                                 chip::ICDConfigurationData::GetInstance().GetSlowPollingInterval().count()));
 
     return CHIP_NO_ERROR;