Skip to content

Commit 19aeeb3

Browse files
authored
ESP32: disable debug mode when compiler optimization assertions are disabled (#38384) (#38658)
Earlier we were setting is_debug to TRUE when assertions were disabled and it is incorrect. Earlier we were setting is_debug to TRUE when assertions were disabled and it is incorrect. All components would be built using cmake build system would honour the CONFIG_COMPILER_OPTIMIZATION_ASSERTIONS.... configuration. But sources compiled using gn will have -NDEBUG flag by default. This would create a mismatch.
1 parent 266e5fd commit 19aeeb3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

config/esp32/components/chip/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ endif()
4141

4242
if (NOT CMAKE_BUILD_EARLY_EXPANSION)
4343
if (CONFIG_COMPILER_OPTIMIZATION_ASSERTIONS_DISABLE)
44-
set(is_debug TRUE)
45-
else()
4644
set(is_debug FALSE)
45+
else()
46+
set(is_debug TRUE)
4747
endif()
4848
endif()
4949

0 commit comments

Comments
 (0)