Apply suggestions from code review

Co-authored-by: Junior Martinez <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

@@ -27,8 +27,4 @@ CHIP_ERROR CookSurfaceEndpoint::Init()
     return CHIP_NO_ERROR;
 }
 
-void CookSurfaceEndpoint::HandleOffCommand()
-{
-    // TODO: Implement the logic to handle the "off" command
-    return;
-}
+void CookSurfaceEndpoint::HandleOffCommand() {}

examples/oven-app/oven-app-common/src/CookTopEndpoint.cpp

@@ -27,8 +27,4 @@ CHIP_ERROR CookTopEndpoint::Init()
     return CHIP_NO_ERROR;
 }
 
-void CookTopEndpoint::HandleOffCommand()
-{
-    // TODO: Implement the logic to handle the "off" command
-    return;
-}
+void CookTopEndpoint::HandleOffCommand() {}

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

@@ -86,7 +86,7 @@ const detail::Structs::ModeOptionStruct::Type OvenModeDelegate::skModeOptions[kM
 
 CHIP_ERROR OvenModeDelegate::Init()
 {
-    // Set the instance for the mode base delegate
+    // No initialization required for OvenModeDelegate
     return CHIP_NO_ERROR;
 }
 

examples/oven-app/silabs/include/AppConfig.h

@@ -25,4 +25,4 @@
 
 #define APP_TASK_NAME "Oven"
 
-#define BLE_DEV_NAME "Silabs-Oven"
+#define BLE_DEV_NAME "SL-" APP_TASK_NAME

examples/oven-app/silabs/include/OvenManager.h

@@ -53,11 +53,11 @@ class OvenManager
     chip::app::Clusters::AppSupportedTemperatureLevelsDelegate mTemperatureControlDelegate;
 
     // Define the endpoint ID for the Oven
-    static constexpr chip::EndpointId kOvenEndpoint1                         = 1;
-    static constexpr chip::EndpointId kTemperatureControlledCabinetEndpoint2 = 2;
-    static constexpr chip::EndpointId kCookTopEndpoint3                      = 3;
-    static constexpr chip::EndpointId kCookSurfaceEndpoint4                  = 4;
-    static constexpr chip::EndpointId kCookSurfaceEndpoint5                  = 5;
+    static constexpr chip::EndpointId kOvenEndpoint                         = 1;
+    static constexpr chip::EndpointId kTemperatureControlledCabinetEndpoint = 2;
+    static constexpr chip::EndpointId kCookTopEndpoint                      = 3;
+    static constexpr chip::EndpointId kCookSurfaceEndpoint1                  = 4;
+    static constexpr chip::EndpointId kCookSurfaceEndpoint2                  = 5;
 
     chip::app::Clusters::Oven::OvenEndpoint mOvenEndpoint1;
     chip::app::Clusters::TemperatureControlledCabinet::TemperatureControlledCabinetEndpoint mTemperatureControlledCabinetEndpoint2{

examples/oven-app/silabs/src/AppSupportedTemperatureLevelsDelegate.cpp

@@ -24,7 +24,7 @@ using namespace chip;
 using namespace chip::app::Clusters;
 using namespace chip::app::DataModel;
 
-bool AppSupportedTemperatureLevelsDelegate::RegisterSupportedLevels(EndpointId endpoint, const CharSpan * levels,
+CHIP_ERROR AppSupportedTemperatureLevelsDelegate::RegisterSupportedLevels(EndpointId endpoint, const CharSpan * levels,
                                                                     uint8_t levelCount)
 {
     if (levels == nullptr || levelCount == 0)
@@ -54,7 +54,6 @@ bool AppSupportedTemperatureLevelsDelegate::RegisterSupportedLevels(EndpointId e
 
 uint8_t AppSupportedTemperatureLevelsDelegate::Size()
 {
-    ChipLogProgress(AppServer, "AppSupportedTemperatureLevelsDelegate::Size() called for endpoint %d", mEndpoint);
     for (size_t i = 0; i < mRegisteredEndpointCount; ++i)
     {
         const EndpointPair & endpointPair = supportedOptionsByEndpoints[i];
@@ -70,25 +69,20 @@ uint8_t AppSupportedTemperatureLevelsDelegate::Size()
 
 CHIP_ERROR AppSupportedTemperatureLevelsDelegate::Next(MutableCharSpan & item)
 {
-    ChipLogProgress(AppServer, "AppSupportedTemperatureLevelsDelegate::Next() called for endpoint %d, index %d", mEndpoint, mIndex);
     for (size_t i = 0; i < mRegisteredEndpointCount; ++i)
     {
         const EndpointPair & endpointPair = supportedOptionsByEndpoints[i];
         if (endpointPair.mEndpointId == mEndpoint)
         {
             if (mIndex < endpointPair.mSize)
             {
-                ChipLogProgress(AppServer, "Returning temperature level: %.*s",
-                                static_cast<int>(endpointPair.mTemperatureLevels[mIndex].size()),
-                                endpointPair.mTemperatureLevels[mIndex].data());
                 CHIP_ERROR err = CopyCharSpanToMutableCharSpan(endpointPair.mTemperatureLevels[mIndex], item);
                 if (err == CHIP_NO_ERROR)
                 {
                     mIndex++;
                 }
                 return err;
             }
-            ChipLogProgress(AppServer, "List exhausted at index %d", mIndex);
             return CHIP_ERROR_PROVIDER_LIST_EXHAUSTED;
         }
     }