Skip to content

Commit d3cb6fa

Browse files
arun-silabsjepenven-silabsCopilot
authored
Apply suggestions from code review
Co-authored-by: Jean-Francois Penven <[email protected]> Co-authored-by: Copilot <[email protected]>
1 parent efceeac commit d3cb6fa

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

examples/oven-app/oven-app-common/include/CookTopEndpoint.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CookTopEndpoint
3939
CHIP_ERROR Init();
4040

4141
/**
42-
* @brief Set On/Off state for the CookSurface.
42+
* @brief Set On/Off state for the CookTop
4343
* @param state Desired On/Off state.
4444
*
4545
* Note: This helper writes the OnOff attribute to the CHIP attribute storage and

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ using namespace chip::app::Clusters::CookSurface;
2626

2727
CHIP_ERROR CookSurfaceEndpoint::Init()
2828
{
29+
// Placeholder for user Init
2930
return CHIP_NO_ERROR;
3031
}
3132

examples/oven-app/silabs/src/OvenManager.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include "AppConfig.h"
2929
#include "AppTask.h"
3030

31-
#include <app-common/zap-generated/attributes/Accessors.h>
3231
#include <platform/CHIPDeviceLayer.h>
3332

3433
#define MAX_TEMPERATURE 30000
@@ -195,7 +194,6 @@ void OvenManager::OvenModeAttributeChangeHandler(chip::EndpointId endpointId, ch
195194
event.Type = AppEvent::kEventType_UIUpdate;
196195
event.Handler = OvenActionHandler;
197196
AppTask::GetAppTask().PostEvent(&event);
198-
return;
199197
}
200198

201199
void OvenManager::OvenActionHandler(AppEvent * aEvent)

0 commit comments

Comments
 (0)