Skip to content

Commit e15d883

Browse files
authored
Delay the commissioning window ended check by one second (#37352)
The test plan states that the test should wait till the time is over. The current test waits exactly as long as the window is. If there are cases where on the DUT the timers are not that accurate this "very exact check" could lead to false positives. We had such cases with matter.js in the CI here and there because Node.js Timers are not 100% accurate and depending on other tasks in the event loop closing the window could be slightly delayed. One CI example can be seen in https://github.com/project-chip/matter.js/actions/runs/12964616630/job/36163527843#step:4:3695 The analysis of a comparable showed this: * 10:17:46.984 matter.js enables the timer for 180s * 10:17:46.987 matter.js send InvokeResponse * 10:17:46.989 till 10:20:46.989 test-runner wait, so exactly 180s * 10:20:46.992 we get the read and we are still on "window opened" * 10:20:46.994 we close the window - 10:20:46.996 trx is unlocked so done So the test did the read 4ms too early. This proposal could make this test a bit more false positive secure also for prodiction certifications.
1 parent f85e58f commit e15d883

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/app/tests/suites/certification/Test_TC_CADMIN_1_3.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,8 +420,9 @@ tests:
420420
command: "WaitForMs"
421421
arguments:
422422
values:
423+
# Wait one second longer to make sure the DUT had time to end the commissioning window
423424
- name: "ms"
424-
value: PIXIT.CADMIN.CwDuration * 1000
425+
value: (PIXIT.CADMIN.CwDuration + 1 ) * 1000
425426

426427
- label:
427428
"Step 11: TH_CR2 reads the window status to verify the DUT_CE window

0 commit comments

Comments
 (0)