|
| 1 | +From 9e212f8578e945598096b90e18b91a662d5f98e6 Mon Sep 17 00:00:00 2001 |
| 2 | +From: Philippe Coval < [email protected]> |
| 3 | +Date: Tue, 23 Jan 2024 16:27:50 +0100 |
| 4 | +Subject: [PATCH] UIC-3202: Relax compiler warnings to support more compilers |
| 5 | + |
| 6 | +Threating warning as error is a good practice durring development phase, |
| 7 | +for release it's ok to relax this to support more (future) compilers |
| 8 | +and then provide best effort support on non supported environements. |
| 9 | + |
| 10 | +For instance we might allow users to support stable version of gcc |
| 11 | +(gcc-13 currently which is not yet enabled in our CI) |
| 12 | + |
| 13 | +Of course this change should be reverted on development branch, ASAP, |
| 14 | +and introduced again for next releases. |
| 15 | + |
| 16 | +Ideally it should be near to release tags. |
| 17 | + |
| 18 | +Origin: uic/pull-requests/2704/overview |
| 19 | +Relate-to: uic/pull-requests/2705/overview?commentId=796680 |
| 20 | +Relate-to: /x/FND4Dg#BrainstormItems-Identifystandardsbreakage |
| 21 | +Forwarded: uic/pull-requests/2704/overview |
| 22 | +Signed-off-by: Philippe Coval < [email protected]> |
| 23 | +--- |
| 24 | + cmake/include/compiler_options.cmake | 4 ++-- |
| 25 | + 1 file changed, 2 insertions(+), 2 deletions(-) |
| 26 | + |
| 27 | +diff --git a/cmake/include/compiler_options.cmake b/cmake/include/compiler_options.cmake |
| 28 | +index 751ffe84bd..1f83caa008 100644 |
| 29 | +--- a/cmake/include/compiler_options.cmake |
| 30 | ++++ b/cmake/include/compiler_options.cmake |
| 31 | +@@ -31,8 +31,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON) # Do not allow fallback to previous C++ |
| 32 | + set(CMAKE_CXX_EXTENSIONS ON) # Enable gnu++11 extentions |
| 33 | + |
| 34 | + # Set compiler Flags |
| 35 | +-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe -Werror -Wall") |
| 36 | +-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pipe -Werror -Wall") |
| 37 | ++set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe -Wall") |
| 38 | ++set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pipe -Wall") |
| 39 | + |
| 40 | + # Only add code coverage when CMAKE_GCOV is True |
| 41 | + if(CMAKE_GCOV) |
| 42 | +-- |
| 43 | +2.39.5 |
| 44 | + |
0 commit comments