Skip to content

Commit d6c5fc3

Browse files
committed
Renaming of XML to TTP_initial_conditions
1 parent 6eccea6 commit d6c5fc3

File tree

10 files changed

+103
-66
lines changed

10 files changed

+103
-66
lines changed

Code/Source/solver/Parameters.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1665,7 +1665,7 @@ void DomainParameters::print_parameters()
16651665

16661666
stimulus.print_parameters();
16671667

1668-
initial_conditions.print_parameters();
1668+
ttp_initial_conditions.print_parameters();
16691669

16701670
fluid_viscosity.print_parameters();
16711671

@@ -1713,7 +1713,7 @@ void DomainParameters::set_values(tinyxml2::XMLElement* domain_elem, bool from_e
17131713
stimulus.set_values(item);
17141714

17151715
} else if (name == InitialConditionsParameters::xml_element_name_) {
1716-
initial_conditions.set_values(item);
1716+
ttp_initial_conditions.set_values(item);
17171717

17181718
} else if (name == FluidViscosityParameters::xml_element_name_ || name == SolidViscosityParameters::xml_element_name_) {
17191719
auto eq_type = consts::equation_name_to_type.at(equation.value());
@@ -3145,10 +3145,10 @@ void LinearSolverParameters::set_values(tinyxml2::XMLElement* xml_elem)
31453145
// InitialConditionsParameters //
31463146
//////////////////////////////////////////////////////////
31473147

3148-
// Process parameters for the 'Initial_conditions' XML element.
3148+
// Process parameters for the 'TTP_initial_conditions' XML element.
31493149

31503150
/// @brief Define the XML element name for initial conditions parameters.
3151-
const std::string InitialConditionsParameters::xml_element_name_ = "Initial_conditions";
3151+
const std::string InitialConditionsParameters::xml_element_name_ = "TTP_initial_conditions";
31523152

31533153
InitialConditionsParameters::InitialConditionsParameters()
31543154
{
@@ -3196,8 +3196,8 @@ void InitialConditionsParameters::set_values(tinyxml2::XMLElement* xml_elem)
31963196
// InitialStatesParameters //
31973197
//////////////////////////////////////////////////////////
31983198

3199-
/// @brief Define the XML element name for initial states parameters.
3200-
const std::string InitialStatesParameters::xml_element_name_ = "Initial_States";
3199+
/// @brief Define the XML element name for initial states parameters (Initial_states).
3200+
const std::string InitialStatesParameters::xml_element_name_ = "Initial_states";
32013201

32023202
InitialStatesParameters::InitialStatesParameters()
32033203
{

Code/Source/solver/Parameters.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,7 +1181,7 @@ class FiberReinforcementStressParameters : public ParameterLists
11811181
};
11821182

11831183
/// @brief The GatingVariablesParameters class stores parameters for the
1184-
/// 'Gating_variables' XML element under Initial_conditions.
1184+
/// 'Gating_variables' XML element under TTP_initial_conditions.
11851185
class GatingVariablesParameters : public ParameterLists
11861186
{
11871187
public:
@@ -1217,7 +1217,7 @@ class GatingVariablesParameters : public ParameterLists
12171217
};
12181218

12191219
/// @brief The InitialStatesParameters class stores parameters for the
1220-
/// 'Initial_States' XML element under Initial_conditions.
1220+
/// 'Initial_states' XML element under TTP_initial_conditions.
12211221
class InitialStatesParameters : public ParameterLists
12221222
{
12231223
public:
@@ -1241,7 +1241,7 @@ class InitialStatesParameters : public ParameterLists
12411241
};
12421242

12431243
/// @brief The InitialConditionsParameters class stores parameters for the
1244-
/// 'Initial_conditions' XML element under Domain.
1244+
/// 'TTP_initial_conditions' XML element under Domain.
12451245
class InitialConditionsParameters : public ParameterLists
12461246
{
12471247
public:
@@ -1288,7 +1288,7 @@ class DomainParameters : public ParameterLists
12881288
StimulusParameters stimulus;
12891289
FluidViscosityParameters fluid_viscosity;
12901290
SolidViscosityParameters solid_viscosity;
1291-
InitialConditionsParameters initial_conditions;
1291+
InitialConditionsParameters ttp_initial_conditions;
12921292

12931293
// Attributes.
12941294
Parameter<std::string> id;

Code/Source/solver/read_files.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1039,11 +1039,11 @@ void read_cep_domain(Simulation* simulation, EquationParameters* eq_params, Doma
10391039
}
10401040
}
10411041

1042-
if (domain_params->initial_conditions.defined()) {
1042+
if (domain_params->ttp_initial_conditions.defined()) {
10431043

1044-
auto& initial_conditions_params = domain_params->initial_conditions;
1045-
if (initial_conditions_params.initial_states.defined()) {
1046-
auto& initial_states_params = initial_conditions_params.initial_states;
1044+
auto& ttp_initial_conditions_params = domain_params->ttp_initial_conditions;
1045+
if (ttp_initial_conditions_params.initial_states.defined()) {
1046+
auto& initial_states_params = ttp_initial_conditions_params.initial_states;
10471047
bool any_set = false;
10481048
if (initial_states_params.V.defined()) { lDmn.cep.ttp_initial_state.V = initial_states_params.V.value(); any_set = true; }
10491049
if (initial_states_params.K_i.defined()) { lDmn.cep.ttp_initial_state.K_i = initial_states_params.K_i.value(); any_set = true; }
@@ -1055,8 +1055,8 @@ void read_cep_domain(Simulation* simulation, EquationParameters* eq_params, Doma
10551055
lDmn.cep.ttp_user_initial_state = any_set;
10561056
}
10571057

1058-
if (initial_conditions_params.gating_variables.defined()) {
1059-
auto& gating_variables_params = initial_conditions_params.gating_variables;
1058+
if (ttp_initial_conditions_params.gating_variables.defined()) {
1059+
auto& gating_variables_params = ttp_initial_conditions_params.gating_variables;
10601060
bool any_set = false;
10611061
// Rectifier current gating variables
10621062
if (gating_variables_params.x_r1_rectifier.defined()) { lDmn.cep.ttp_initial_state.x_r1 = gating_variables_params.x_r1_rectifier.value(); any_set = true; }

TTP_Initial_Conditions_Flow_Control.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,21 +54,21 @@ auto root_element = doc.FirstChildElement(FSI_FILE.c_str());
5454
- **Location**: `Code/Source/solver/Parameters.cpp:1673`
5555
- **Action**:
5656
- Iterates through child elements of `<Domain>`
57-
- When encountering `<Initial_conditions>` element:
57+
- When encountering `<TTP_initial_conditions>` element:
5858
- Creates/calls `InitialConditionsParameters::set_values()`
5959

6060
### Step 1.5: Initial States Parsing
6161
- **Function**: `InitialConditionsParameters::set_values(tinyxml2::XMLElement* xml_elem)`
6262
- **Location**: `Code/Source/solver/Parameters.cpp:2986`
6363
- **Action**:
64-
- Checks for `<Initial_States>` child element
64+
- Checks for `<Initial_states>` child element
6565
- If found, calls `InitialStatesParameters::set_values()`
6666

6767
### Step 1.6: Individual State Variable Parsing
6868
- **Function**: `InitialStatesParameters::set_values(tinyxml2::XMLElement* xml_elem)`
6969
- **Location**: `Code/Source/solver/Parameters.cpp:3043`
7070
- **Action**:
71-
- Iterates through child elements of `<Initial_States>`
71+
- Iterates through child elements of `<Initial_states>`
7272
- For each element (e.g., `<V>`, `<K_i>`, `<Na_i>`, etc.):
7373
- Extracts text value using `item->GetText()`
7474
- Calls `set_parameter_value(name, value)` to store the value
@@ -97,7 +97,7 @@ auto root_element = doc.FirstChildElement(FSI_FILE.c_str());
9797
- **Function**: `read_cep_domain(CepMod* cep_mod, Simulation* simulation, DomainParameters* domain_params, cepModelType& lDmn)`
9898
- **Location**: `Code/Source/solver/read_files.cpp:1058`
9999
- **Action**:
100-
- Checks if `domain_params->initial_conditions.defined()` is true
100+
- Checks if `domain_params->ttp_initial_conditions.defined()` is true
101101
- If initial conditions are defined in XML, proceeds to extract and store values
102102

103103
### Step 2.2: Initial States Storage
@@ -378,16 +378,16 @@ XML File (solver.xml)
378378
<Electrophysiology_model> TTP </Electrophysiology_model>
379379
<Myocardial_zone> epi </Myocardial_zone>
380380

381-
<Initial_conditions>
382-
<Initial_States>
381+
<TTP_initial_conditions>
382+
<Initial_states>
383383
<V>18.167</V>
384384
<K_i>136.897</K_i>
385385
<Na_i>8.6105</Na_i>
386386
<Ca_i>1.2592E-4</Ca_i>
387387
<Ca_ss>3.6181E-4</Ca_ss>
388388
<Ca_sr>3.6399</Ca_sr>
389389
<R_bar>0.9078</R_bar>
390-
</Initial_States>
390+
</Initial_states>
391391

392392
<Gating_variables>
393393
<x_r1_rectifier>6.368E-3</x_r1_rectifier>
@@ -403,7 +403,7 @@ XML File (solver.xml)
403403
<s_out>0.9941</s_out>
404404
<r_out>4.2757E-5</r_out>
405405
</Gating_variables>
406-
</Initial_conditions>
406+
</TTP_initial_conditions>
407407
</Domain>
408408
```
409409

tests/cases/cep/spiral_TTP_2d/README.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ Initial conditions for the Ten-tusscher-Panfilov (TTP) EP model to be specified
1010

1111
## Overview
1212

13-
The user-defined initial conditions override system allows users to specify custom initial states and gating variables directly in the XML configuration file. When `Initial_conditions` is specified in the XML, it automatically overrides the default initial conditions that would normally be set based on the myocardial zone (epicardium, endocardium, or midmyocardium).
13+
The user-defined initial conditions override system allows users to specify custom initial states and gating variables directly in the XML configuration file. When `TTP_initial_conditions` is specified in the XML, it automatically overrides the default initial conditions that would normally be set based on the myocardial zone (epicardium, endocardium, or midmyocardium).
1414

1515
## How It Works
1616

17-
1. **XML Specification**: Users specify `Initial_conditions` in the domain configuration
17+
1. **XML Specification**: Users specify `TTP_initial_conditions` in the domain configuration
1818
2. **Flag Activation**: The system automatically sets a flag indicating user-defined initial conditions are being used
1919
3. **Override Logic**: During initialization, the system uses the user-defined values instead of defaults
20-
4. **Fallback**: If no `Initial_conditions` are specified, the system uses default initialization based on myocardial zone
20+
4. **Fallback**: If no `TTP_initial_conditions` are specified, the system uses default initialization based on myocardial zone
2121

2222
## XML Configuration
2323

@@ -28,16 +28,16 @@ The user-defined initial conditions override system allows users to specify cust
2828
<Electrophysiology_model> TTP </Electrophysiology_model>
2929
<Myocardial_zone> epicardium </Myocardial_zone>
3030
<!-- User-defined initial conditions - these override the default epicardium values -->
31-
<Initial_conditions>
32-
<Initial_States>
31+
<TTP_initial_conditions>
32+
<Initial_states>
3333
<V>-82.0</V>
3434
<K_i>135.0</K_i>
3535
<Na_i>9.5</Na_i>
3636
<Ca_i>0.00015</Ca_i>
3737
<Ca_ss>0.00015</Ca_ss>
3838
<Ca_sr>0.18</Ca_sr>
3939
<R_bar>0.0</R_bar>
40-
</Initial_States>
40+
</Initial_states>
4141
<Gating_variables>
4242
<Rectifier_current>
4343
<x_r1>0.008</x_r1>
@@ -60,7 +60,7 @@ The user-defined initial conditions override system allows users to specify cust
6060
<r>0.001</r>
6161
</Transient_outward_current>
6262
</Gating_variables>
63-
</Initial_conditions>
63+
</TTP_initial_conditions>
6464
</Domain>
6565
```
6666

@@ -71,20 +71,20 @@ The user-defined initial conditions override system allows users to specify cust
7171
<Electrophysiology_model> TTP </Electrophysiology_model>
7272
<Myocardial_zone> epicardium </Myocardial_zone>
7373
<!-- Partial override - only specified values override defaults -->
74-
<Initial_conditions>
75-
<Initial_States>
74+
<TTP_initial_conditions>
75+
<Initial_states>
7676
<V>-82.0</V>
7777
<K_i>135.0</K_i>
7878
<!-- Other values (Na_i, Ca_i, Ca_ss, Ca_sr, R_bar) use epicardium defaults -->
79-
</Initial_States>
79+
</Initial_states>
8080
<Gating_variables>
8181
<Rectifier_current>
8282
<x_r1>0.008</x_r1>
8383
<!-- x_r2 and x_s use epicardium defaults -->
8484
</Rectifier_current>
8585
<!-- Other gating variable groups use epicardium defaults -->
8686
</Gating_variables>
87-
</Initial_conditions>
87+
</TTP_initial_conditions>
8888
</Domain>
8989
```
9090

@@ -94,7 +94,7 @@ The user-defined initial conditions override system allows users to specify cust
9494
<Domain id="1">
9595
<Electrophysiology_model> TTP </Electrophysiology_model>
9696
<Myocardial_zone> epicardium </Myocardial_zone>
97-
<!-- No Initial_conditions specified - uses epicardium defaults -->
97+
<!-- No TTP_initial_conditions specified - uses epicardium defaults -->
9898
</Domain>
9999
```
100100

@@ -137,7 +137,7 @@ The user-defined initial conditions override system allows users to specify cust
137137

138138
1. **Added Flag**: `user_initial_conditions_defined` flag in `CepModTtp` class
139139
2. **Modified Initialization**: `init()` method checks the flag and uses user values when set
140-
3. **XML Integration**: `read_cep_domain()` sets the flag when `Initial_conditions` is specified
140+
3. **XML Integration**: `read_cep_domain()` sets the flag when `TTP_initial_conditions` is specified
141141

142142
### Logic Flow
143143

@@ -150,7 +150,7 @@ The user-defined initial conditions override system allows users to specify cust
150150

151151
```cpp
152152
// In read_files.cpp
153-
if (domain_params->initial_conditions.defined()) {
153+
if (domain_params->ttp_initial_conditions.defined()) {
154154
// Read and set user-defined values
155155
cep_mod.ttp.set_user_initial_conditions_flag(true);
156156
}

tests/cases/cep/spiral_TTP_2d/solver.xml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,16 @@
6262
<Isotropic_conductivity> 0.1171 </Isotropic_conductivity>
6363

6464
<Myocardial_zone> epi </Myocardial_zone>
65-
<Initial_conditions>
66-
<Initial_States>
65+
<TTP_initial_conditions>
66+
<Initial_states>
6767
<V>18.167</V>
6868
<K_i>136.897</K_i>
6969
<Na_i>8.6105</Na_i>
7070
<Ca_i>1.2592E-4</Ca_i>
7171
<Ca_ss>3.6181E-4</Ca_ss>
7272
<Ca_sr>3.6399</Ca_sr>
7373
<R_bar>0.9078</R_bar>
74-
</Initial_States>
74+
</Initial_states>
7575

7676
<Gating_variables>
7777
<x_r1_rectifier>6.368E-3</x_r1_rectifier>
@@ -87,7 +87,7 @@
8787
<s_out>0.9941</s_out>
8888
<r_out>4.2757E-5</r_out>
8989
</Gating_variables>
90-
</Initial_conditions>
90+
</TTP_initial_conditions>
9191
<ODE_solver> RK </ODE_solver>
9292
</Domain>
9393

@@ -113,16 +113,16 @@
113113
<Isotropic_conductivity> 0.1171 </Isotropic_conductivity>
114114

115115
<Myocardial_zone> epi </Myocardial_zone>
116-
<Initial_conditions>
117-
<Initial_States>
116+
<TTP_initial_conditions>
117+
<Initial_states>
118118
<V>-44.756</V>
119119
<K_i>136.88</K_i>
120120
<Na_i>8.5907</Na_i>
121121
<Ca_i>3.0084E-4</Ca_i>
122122
<Ca_ss>2.5462E-3</Ca_ss>
123123
<Ca_sr>3.5292</Ca_sr>
124124
<R_bar>0.7235</R_bar>
125-
</Initial_States>
125+
</Initial_states>
126126

127127
<Gating_variables>
128128
<x_r1_rectifier>0.9739</x_r1_rectifier>
@@ -138,7 +138,7 @@
138138
<s_out>0.4095</s_out>
139139
<r_out>7.857E-4</r_out>
140140
</Gating_variables>
141-
</Initial_conditions>
141+
</TTP_initial_conditions>
142142
<ODE_solver> RK </ODE_solver>
143143
</Domain>
144144

@@ -152,16 +152,16 @@
152152
<Isotropic_conductivity> 0.1171 </Isotropic_conductivity>
153153

154154
<Myocardial_zone> epi </Myocardial_zone>
155-
<Initial_conditions>
156-
<Initial_States>
155+
<TTP_initial_conditions>
156+
<Initial_states>
157157
<V>-11.612</V>
158158
<K_i>136.88</K_i>
159159
<Na_i>8.5916</Na_i>
160160
<Ca_i>3.486E-4</Ca_i>
161161
<Ca_ss>1.312E-2</Ca_ss>
162162
<Ca_sr>3.4619</Ca_sr>
163163
<R_bar>0.6875</R_bar>
164-
</Initial_States>
164+
</Initial_states>
165165

166166
<Gating_variables>
167167
<x_r1_rectifier>9.882E-1</x_r1_rectifier>
@@ -177,7 +177,7 @@
177177
<s_out>7.9355E-2</s_out>
178178
<r_out>1.0429E-2</r_out>
179179
</Gating_variables>
180-
</Initial_conditions>
180+
</TTP_initial_conditions>
181181
<ODE_solver> RK </ODE_solver>
182182
</Domain>
183183

tests/cases/cep/spiral_TTP_xmlsep/domain-1_EPmodel.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<svMultiPhysicsFile version="0.1">
33

44
<Electrophysiology_model> TTP </Electrophysiology_model>
5-
<G_Na> 10 </G_Na>
5+
<G_Na> 14.838 </G_Na>
66
<G_CaL> 3.98E-5 </G_CaL>
77
<G_Kr> 0.153 </G_Kr>
88
<G_Ks> 0.392 </G_Ks>
@@ -11,16 +11,16 @@
1111

1212
<Myocardial_zone> epi </Myocardial_zone>
1313

14-
<Initial_conditions>
15-
<Initial_States>
14+
<TTP_initial_conditions>
15+
<Initial_states>
1616
<V>18.167</V>
1717
<K_i>136.897</K_i>
1818
<Na_i>8.6105</Na_i>
1919
<Ca_i>1.2592E-4</Ca_i>
2020
<Ca_ss>3.6181E-4</Ca_ss>
2121
<Ca_sr>3.6399</Ca_sr>
2222
<R_bar>0.9078</R_bar>
23-
</Initial_States>
23+
</Initial_states>
2424

2525
<Gating_variables>
2626
<x_r1_rectifier>6.368E-3</x_r1_rectifier>
@@ -36,7 +36,7 @@
3636
<s_out>0.9941</s_out>
3737
<r_out>4.2757E-5</r_out>
3838
</Gating_variables>
39-
</Initial_conditions>
39+
</TTP_initial_conditions>
4040

4141
<ODE_solver> RK </ODE_solver>
4242

0 commit comments

Comments
 (0)