-
Notifications
You must be signed in to change notification settings - Fork 24
Description
Description
The reference geometry cvOneDBFSolver.cxx).
However, in the material model classes (e.g. cvOneDMaterialOlufsen.cxx), the reference radius
These two approaches are clearly mathematically inconsistent, since interpolating areas and then taking a square root
This inconsistency leads to a mismatch in the initial geometry and becomes visible when looking at the pressure at
Proposed fix:
- Either update line 1341 in
cvOneDBFSolver.cxxto interpolate radii instead of areas (and compute$A_0$ from them), - or update the material classes to interpolate areas instead of radii.
bug_RCA-A18-B17_pressure_along_centerline.pdf
Reproduction
Run a 1D simulation over any vessel geometry, selecting for the material model
Environment info
OS: Ubuntu 22.04
Skyline solver
commit: 66b31b4
Expected behavior
The pressure at the initial time, when imposing e.g.
Additional context
When the parameters of the material model are changed to make the vessel quasi-rigid, the effect of this bug becomes more evident.
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines