Skip to content

Commit 23ef80a

Browse files
Minor comments from JOSS review (#170)
1 parent 8e1f049 commit 23ef80a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

paper/paper.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Simply specifying a `.json` dictionary of lumped-parameter "blocks" -- such as b
5252
In addition, the package includes Python and C++ interfaces to facilitate its use with other software packages.
5353
For example, it can be integrated into Python-based optimization and uncertainty quantification applications [@zanoni2024; @Lee2024; @richter2024bayesian; @menon2024personalizeduncertainty].
5454
It can also be interfaced with C++/Fortran software for high-fidelity cardiovascular flow simulations, where `svZeroDSolver` can conveniently provide physiological lumped-parameter boundary conditions [@menon2023predictors; @menon2024personalized].
55-
`svZeroDSolver` includes an application, called `svZeroDCalibrator`, to automatically calibrate parameters of a given zero-dimensional model based independent hemodynamic measurements or high-fidelity simulations -- thus improving the accuracy of zero-dimensional models [@richter2024bayesian].
55+
`svZeroDSolver` includes an application, called `svZeroDCalibrator`, to automatically calibrate parameters of a given zero-dimensional model based on independent hemodynamic measurements or high-fidelity simulations -- thus improving the accuracy of zero-dimensional models [@richter2024bayesian].
5656
It also includes graphical interfaces to interactively create lumped-parameter models for simulations, as well as to visualize the simulated anatomy and hemodynamics.
5757

5858
# Statement of need
@@ -93,14 +93,16 @@ This combination of features makes `svZeroDSolver` uniquely applicable to a wide
9393

9494
While there are other open-source projects that provide the functionality for cardiovascular flow modeling, and specifically zero-dimensional flow modeling, `svZeroDSolver` has several features that distinguish it from previous work.
9595
In particular, prior packages have primarily focused on multi-physics finite element modeling for cardiovascular biomechanics [@crimson2021; @Zhu2022; @AFRICA2024109039; @Hirschvogel2024].
96-
Although these projects allow the implementation of simple zero-dimensional models, usually as boundary conditions to three-dimensional models, the primary focus is on the modeling of full three-dimensional fluid and tissue mechanics.
96+
Although these projects allow the implementation of simple zero-dimensional models, either as boundary conditions to three-dimensional models or as simple stand-alone zero-dimensional models, the primary focus is on the modeling of full three-dimensional fluid and tissue mechanics.
97+
Due to this, they generally lack the variety and/or modular functionality to create a broad range of user-specified zero-dimensional flow models.
9798
There are, however, packages aimed specifically at reduced-order modeling for cardiovascular flows.
9899
For example, the `SimVascular` project includes [`svOneDSolver`](https://github.com/SimVascular/svOneDSolver) for the purpose of one-dimensional blood flow modeling.
99100
Another popular package for one-dimensional blood flow simulations is `Nektar1D` [@alastruey2012arterial].
100101
Similarly, `Artery.FE` implements one-dimensional blood flow modeling using the FEniCS finite element framework [@Agdestein2018], the `VaMpy` toolkit includes a package for modeling one-dimensional blood flow using the Lax-Wendroff finite difference method [@Diem-2017], and `openBF` is a finite volume implementation of one-dimensional blood flow [@benemerito2024openbf].
101102

102-
In the zero-dimensional modeling context, `CRIMSON` [@crimson2021] and `lifex-cfd` [@AFRICA2024109039] include the ability to simulate simple zero-dimensional blood flow models, primarily as boundary conditions to three-dimensional simulations.
103-
However, their focus is on multi-physics simulations of cardiovascular biomechanics, therefore they are not stand-alone and modular zero-dimensional flow solvers.
103+
In the zero-dimensional modeling context, `CRIMSON` [@crimson2021], `lifex-cfd` [@AFRICA2024109039], and `Ambit` [@Hirschvogel2024] include the ability to simulate simple zero-dimensional blood flow models.
104+
However, as mentioned above, their focus is on multi-physics simulations of cardiovascular biomechanics.
105+
Therefore, they support a limited set of stand-alone zero-dimensional models and do not feature the modularity that enables the creation of a large variety of zero-dimensional models as in `svZeroDSolver`.
104106
The `CellML` and `CVSim` packages include a limited set of stand-alone zero-dimensional flow models for specific anatomies/applications [@cellml; @heldt2010cvsim], but they do not provide the modular functionality to specify unique anatomical models.
105107
In addition, there have been other packages that use zero-dimensional modeling techniques with a focus on statistical analysis, cardiac electromechanics, or specific anatomical models [@HUTTARY2017104; @REGAZZONI2021104641; @rosalia2021object].
106108
However, these packages are either not focused on zero-dimensional modeling or use MATLAB implementations, which require software licenses and are not free to use.

paper/paper.pdf

452 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)