Added option to specify cardiac period (#127)

Co-authored-by: ricky <[email protected]>
Co-authored-by: Nick Dorn <[email protected]>

Author: 3 people

.github/codecov.yml

@@ -38,3 +38,6 @@ build*/
 
 # Node modules (for directed graph visualization)
 node_modules/
+
+.github
+

.github/workflows/codechecks.yml

@@ -174,10 +174,6 @@ void Model::finalize() {
   for (auto &block : blocks) {
     block->setup_model_dependent_params();
   }
-
-  if (cardiac_cycle_period < 0.0) {
-    cardiac_cycle_period = 1.0;
-  }
 }
 
 int Model::get_num_blocks(bool internal) const {

.github/workflows/documentation.yml

@@ -169,7 +169,6 @@ SimulationParameters load_simulation_params(const nlohmann::json& config) {
           sim_config.value("sim_cycle_to_cycle_percent_error", 1.0) / 100;
     }
     sim_params.sim_external_step_size = 0.0;
-
   } else {
     sim_params.sim_num_cycles = 1;
     sim_params.sim_num_time_steps = sim_config["number_of_time_pts"];
@@ -187,6 +186,7 @@ SimulationParameters load_simulation_params(const nlohmann::json& config) {
   sim_params.output_mean_only = sim_config.value("output_mean_only", false);
   sim_params.output_derivative = sim_config.value("output_derivative", false);
   sim_params.output_all_cycles = sim_config.value("output_all_cycles", false);
+  sim_params.sim_cardiac_period = sim_config.value("cardiac_period", -1.0);
   DEBUG_MSG("Finished loading simulation parameters");
   return sim_params;
 }
@@ -396,7 +396,7 @@ void create_external_coupling(
       if (std::find(std::begin(possible_types), std::end(possible_types),
                     connected_type) == std::end(possible_types)) {
         throw std::runtime_error(
-            "Error: The specified connection type for inlet "
+            "Error: The specified connection type for inlet"
             "external_coupling_block is invalid.");
       }
       connections.push_back({coupling_name, connected_block});

.github/workflows/gui.yml

@@ -23,11 +23,11 @@
 struct SimulationParameters {
   // Negative value indicates this has not
   // been read from config file yet.
-  double sim_time_step_size{0.0};  ///< Simulation time step size
-  double sim_abs_tol{0.0};         ///< Absolute tolerance for simulation
-
-  int sim_num_cycles{0};     ///< Number of cardiac cycles to simulate
-  int sim_pts_per_cycle{0};  ///< Number of time steps per cardiac cycle
+  double sim_time_step_size{0.0};   ///< Simulation time step size
+  double sim_abs_tol{0.0};          ///< Absolute tolerance for simulation
+  double sim_cardiac_period{-1.0};  ///< Cardiac period
+  int sim_num_cycles{0};            ///< Number of cardiac cycles to simulate
+  int sim_pts_per_cycle{0};         ///< Number of time steps per cardiac cycle
   bool use_cycle_to_cycle_error{
       false};  ///< If model does not have RCR boundary conditions, simulate
                ///< model to convergence (based on cycle-to-cycle error of last