feat: ✨ Add a method to pause all players at once (#372)

Author: himanshuGandhiSimform

CHANGELOG.md

@@ -1,10 +1,13 @@
-## 1.2.1 (Unreleased)
+## 1.3.0
 
 - Fixed [#386](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/386) - On permission denied isRecording flag changed
 - Fixed [#384](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/384) - Provide a callback of drag,tap,start and end details on user gesture
 - Fixed [#309](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/309) - Added support for Liner PCM codec in iOS
 - Fixed [#291](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/291) - Codec issue while recording audio on android
-- Fixed wrong codec selection on the platform side on both Android and iOS.
+- Fixed [#391](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/391) - Wrong codec selection on the platform side on Android
+- Fixed [#389](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/389) - Wrong codec selection on the platform side on iOS
+- Fixed [#325](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/325) - Added feature to pause all player controller at once.
+- Fixed [#373](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/373) - Getting error on dispose
 
 ## 1.2.0
 

README.md

@@ -357,6 +357,13 @@ playerController.release();
 playerController.stopAllPlayer();
 ```
 There could be any number of players but you can just call this function from any **one** player and it will stop all the players.
+
+#### Pausing players all at once
+```dart
+playerController.pauseAllPlayers();
+```
+This function works similar to stopAllPlayer but just pauses all players.
+
 #### Disposing the controller
 ```dart
 playerController.dispose();

android/src/main/kotlin/com/simform/audio_waveforms/AudioPlayer.kt

@@ -129,26 +129,19 @@ class AudioPlayer(
         }
     }
 
-    fun stop(result: MethodChannel.Result) {
+    fun stop() {
         stopListening()
         if (playerListener != null) {
             player?.removeListener(playerListener!!)
         }
         isPlayerPrepared = false
         player?.stop()
-        result.success(true)
     }
 
 
-    fun pause(result: MethodChannel.Result) {
-        try {
-            stopListening()
-            player?.pause()
-            result.success(true)
-        } catch (e: Exception) {
-            result.error(Constants.LOG_TAG, "Failed to pause the player", e.toString())
-        }
-
+    fun pause() {
+        stopListening()
+        player?.pause()
     }
 
     fun release(result: MethodChannel.Result) {

android/src/main/kotlin/com/simform/audio_waveforms/AudioRecorder.kt

@@ -13,7 +13,6 @@ import androidx.core.app.ActivityCompat
 import io.flutter.plugin.common.MethodChannel
 import io.flutter.plugin.common.PluginRegistry
 import java.io.IOException
-import java.lang.IllegalStateException
 import kotlin.math.log10
 
 private const val LOG_TAG = "AudioWaveforms"
@@ -62,7 +61,7 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
 
     fun stopRecording(result: MethodChannel.Result, recorder: MediaRecorder?, path: String) {
         try {
-            val hashMap : HashMap<String,Any?> = HashMap()
+            val hashMap: HashMap<String, Any?> = HashMap()
             try {
                 recorder?.stop()
 
@@ -132,9 +131,9 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
     }
 
     override fun onRequestPermissionsResult(
-        requestCode: Int,
-        permissions: Array<out String>,
-        grantResults: IntArray
+            requestCode: Int,
+            permissions: Array<out String>,
+            grantResults: IntArray
     ): Boolean {
         return if (requestCode == RECORD_AUDIO_REQUEST_CODE) {
             successCallback?.onSuccess(grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED)
@@ -146,7 +145,7 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
 
     private fun isPermissionGranted(activity: Activity?): Boolean {
         val result =
-            ActivityCompat.checkSelfPermission(activity!!, permissions[0])
+                ActivityCompat.checkSelfPermission(activity!!, permissions[0])
         return result == PackageManager.PERMISSION_GRANTED
     }
 
@@ -155,8 +154,8 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
         if (!isPermissionGranted(activity)) {
             activity?.let {
                 ActivityCompat.requestPermissions(
-                    it, permissions,
-                    RECORD_AUDIO_REQUEST_CODE
+                        it, permissions,
+                        RECORD_AUDIO_REQUEST_CODE
                 )
             }
         } else {
@@ -179,6 +178,7 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
                     MediaRecorder.AudioEncoder.AAC
                 }
             }
+
             Constants.vorbis -> return MediaRecorder.AudioEncoder.VORBIS
 
             else -> return MediaRecorder.AudioEncoder.AAC
@@ -202,6 +202,7 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
             Constants.amr_nb -> return MediaRecorder.OutputFormat.AMR_NB
             Constants.webm ->
                 return MediaRecorder.OutputFormat.WEBM
+
             Constants.mpeg_2_ts -> {
                 return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
                     MediaRecorder.OutputFormat.MPEG_2_TS
@@ -210,6 +211,7 @@ class AudioRecorder : PluginRegistry.RequestPermissionsResultListener {
                     MediaRecorder.OutputFormat.MPEG_4
                 }
             }
+
             Constants.aac_adts -> return MediaRecorder.OutputFormat.AAC_ADTS
             else -> return MediaRecorder.OutputFormat.MPEG_4
         }

android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt

@@ -7,7 +7,6 @@ import android.os.Build
 import android.util.Log
 import androidx.annotation.NonNull
 import androidx.annotation.RequiresApi
-
 import io.flutter.embedding.engine.plugins.FlutterPlugin
 import io.flutter.embedding.engine.plugins.activity.ActivityAware
 import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding
@@ -18,7 +17,8 @@ import io.flutter.plugin.common.MethodChannel.Result
 import java.io.File
 import java.io.IOException
 import java.text.SimpleDateFormat
-import java.util.*
+import java.util.Date
+import java.util.Locale
 
 
 /** AudioWaveformsPlugin */
@@ -55,13 +55,17 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
                         recorderSettings
                     )
                 } else {
-                    result.error(Constants.LOG_TAG, "Failed to initialise Recorder", "Invalid Arguments")
+                    result.error(
+                        Constants.LOG_TAG,
+                        "Failed to initialise Recorder",
+                        "Invalid Arguments"
+                    )
                 }
             }
 
             Constants.startRecording -> {
                 val useLegacyNormalization =
-                        (call.argument(Constants.useLegacyNormalization) as Boolean?) ?: false
+                    (call.argument(Constants.useLegacyNormalization) as Boolean?) ?: false
                 audioRecorder.startRecorder(result, recorder, useLegacyNormalization)
             }
 
@@ -77,7 +81,12 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
             Constants.pauseRecording -> audioRecorder.pauseRecording(result, recorder)
             Constants.resumeRecording -> audioRecorder.resumeRecording(result, recorder)
             Constants.getDecibel -> audioRecorder.getDecibel(result, recorder)
-            Constants.checkPermission -> audioRecorder.checkPermission(result, activity, result::success)
+            Constants.checkPermission -> audioRecorder.checkPermission(
+                result,
+                activity,
+                result::success
+            )
+
             Constants.preparePlayer -> {
                 val audioPath = call.argument(Constants.path) as String?
                 val volume = call.argument(Constants.volume) as Double?
@@ -109,7 +118,12 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
             Constants.stopPlayer -> {
                 val key = call.argument(Constants.playerKey) as String?
                 if (key != null) {
-                    audioPlayers[key]?.stop(result)
+                    try {
+                        audioPlayers[key]?.stop()
+                        result.success(true)
+                    } catch (e: Exception) {
+                        result.error(Constants.LOG_TAG, "Failed to stop player", e.message)
+                    }
                 } else {
                     result.error(Constants.LOG_TAG, "Player key can't be null", "")
                 }
@@ -118,7 +132,12 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
             Constants.pausePlayer -> {
                 val key = call.argument(Constants.playerKey) as String?
                 if (key != null) {
-                    audioPlayers[key]?.pause(result)
+                    try {
+                        audioPlayers[key]?.pause()
+                        result.success(true)
+                    } catch (e: Exception) {
+                        result.error(Constants.LOG_TAG, "Failed to pause player", e.message)
+                    }
                 } else {
                     result.error(Constants.LOG_TAG, "Player key can't be null", "")
                 }
@@ -140,8 +159,8 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
                     }
                 } else {
                     Log.e(
-                            Constants.LOG_TAG,
-                            "Minimum android O is required for seekTo function to works"
+                        Constants.LOG_TAG,
+                        "Minimum android O is required for seekTo function to works"
                     )
                 }
             }
@@ -168,7 +187,7 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
 
             Constants.getDuration -> {
                 val type =
-                        if ((call.argument(Constants.durationType) as Int?) == 0) DurationType.Current else DurationType.Max
+                    if ((call.argument(Constants.durationType) as Int?) == 0) DurationType.Current else DurationType.Max
                 val key = call.argument(Constants.playerKey) as String?
                 if (key != null) {
                     audioPlayers[key]?.getDuration(result, type)
@@ -183,22 +202,18 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
                 val noOfSample = call.argument(Constants.noOfSamples) as Int?
                 if (key != null) {
                     createOrUpdateExtractor(
-                            playerKey = key,
-                            result = result,
-                            path = path,
-                            noOfSamples = noOfSample ?: 100,
+                        playerKey = key,
+                        result = result,
+                        path = path,
+                        noOfSamples = noOfSample ?: 100,
                     )
                 } else {
                     result.error(Constants.LOG_TAG, "Player key can't be null", "")
                 }
             }
 
             Constants.stopAllPlayers -> {
-                for ((key, _) in audioPlayers) {
-                    audioPlayers[key]?.stop(result)
-                    audioPlayers[key] = null
-                }
-                result.success(true)
+                stopAllPlayer(result)
             }
 
             Constants.finishMode -> {
@@ -209,6 +224,10 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
                 }
             }
 
+            Constants.pauseAllPlayers -> {
+                pauseAllPlayer(result)
+            }
+
             else -> result.notImplemented()
         }
     }
@@ -251,40 +270,40 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
     private fun initPlayer(playerKey: String) {
         if (audioPlayers[playerKey] == null) {
             val newPlayer = AudioPlayer(
-                    context = applicationContext,
-                    channel = channel,
-                    playerKey = playerKey,
+                context = applicationContext,
+                channel = channel,
+                playerKey = playerKey,
             )
             audioPlayers[playerKey] = newPlayer
         }
         return
     }
 
     private fun createOrUpdateExtractor(
-            playerKey: String,
-            noOfSamples: Int,
-            path: String?,
-            result: Result,
+        playerKey: String,
+        noOfSamples: Int,
+        path: String?,
+        result: Result,
     ) {
         if (path == null) {
             result.error(Constants.LOG_TAG, "Path can't be null", "")
             return
         }
         extractors[playerKey] = WaveformExtractor(
-                context = applicationContext,
-                methodChannel = channel,
-                expectedPoints = noOfSamples,
-                key = playerKey,
-                path = path,
-                result = result,
-                extractorCallBack = object : ExtractorCallBack {
-                    override fun onProgress(value: Float) {
-                        if (value == 1.0F) {
-                            result.success(extractors[playerKey]?.sampleData)
-                        }
+            context = applicationContext,
+            methodChannel = channel,
+            expectedPoints = noOfSamples,
+            key = playerKey,
+            path = path,
+            result = result,
+            extractorCallBack = object : ExtractorCallBack {
+                override fun onProgress(value: Float) {
+                    if (value == 1.0F) {
+                        result.success(extractors[playerKey]?.sampleData)
                     }
-
                 }
+
+            }
         )
         extractors[playerKey]?.startDecode()
         extractors[playerKey]?.stop()
@@ -319,4 +338,27 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
             pluginBinding!!.removeRequestPermissionsResultListener(this.audioRecorder)
         }
     }
+
+    private fun stopAllPlayer(result: MethodChannel.Result) {
+        try {
+            for ((key, _) in audioPlayers) {
+                audioPlayers[key]?.stop()
+                audioPlayers[key] = null
+            }
+            result.success(true)
+        } catch (e: Exception) {
+            result.error(Constants.LOG_TAG, "Failed to stop players", e.message)
+        }
+    }
+
+    private fun pauseAllPlayer(result: MethodChannel.Result) {
+        try {
+            for ((key, _) in audioPlayers) {
+                audioPlayers[key]?.pause()
+            }
+            result.success(true)
+        } catch (e: Exception) {
+            result.error(Constants.LOG_TAG, "Failed to pause players", e.message)
+        }
+    }
 }

android/src/main/kotlin/com/simform/audio_waveforms/Utils.kt

@@ -69,6 +69,7 @@ object Constants {
 
     const val resultFilePath = "resultFilePath"
     const val resultDuration = "resultDuration"
+    const val pauseAllPlayers = "pauseAllPlayers"
 }
 
 enum class FinishMode(val value: Int) {

ios/Classes/AudioPlayer.swift

@@ -91,17 +91,15 @@ class AudioPlayer: NSObject, AVAudioPlayerDelegate {
     }
 
 
-    func pausePlayer(result: @escaping FlutterResult) {
+    func pausePlayer() {
         stopListening()
         player?.pause()
-        result(true)
     }
 
-    func stopPlayer(result: @escaping FlutterResult) {
+    func stopPlayer() {
         stopListening()
         player?.stop()
         timer = nil
-        result(true)
     }
 
     func release(result: @escaping FlutterResult) {