Skip to content

Commit 4847799

Browse files
committed
chore!: 🔥 Remove height and width requirement in Showcase.withWidget
1 parent 43c03f7 commit 4847799

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@
4040
- Deprecate [#531](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/531) -
4141
Update deprecated `ShowCaseWidget` removal version.
4242
- Improvement [#505](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/505) -
43-
Fixed example app to run in flutter version `v3.32.5` .
43+
Fixed example app to run in flutter version `v3.32.5`.
44+
- Breaking [#541](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/541) -
45+
Removed height and width from `Showcase.withWidget` constructor, as it is not required anymore.
4446

4547
## [4.0.1]
4648
- Fixed [#493](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/493) - ShowCase.withWidget not showing issue

lib/src/showcase/showcase.dart

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ class Showcase extends StatefulWidget {
112112
this.enableAutoScroll,
113113
this.floatingActionWidget,
114114
this.targetTooltipGap = 10,
115-
}) : height = null,
116-
width = null,
117-
container = null,
115+
}) : container = null,
118116
showcaseKey = key,
119117
assert(
120118
targetTooltipGap >= 0,
@@ -152,8 +150,6 @@ class Showcase extends StatefulWidget {
152150
/// ```dart
153151
/// Showcase.withWidget(
154152
/// key: _customKey,
155-
/// height: 80,
156-
/// width: 140,
157153
/// container: Column(
158154
/// children: [
159155
/// Text(
@@ -172,8 +168,6 @@ class Showcase extends StatefulWidget {
172168
/// ```
173169
const Showcase.withWidget({
174170
required GlobalKey key,
175-
required this.height,
176-
required this.width,
177171
required this.container,
178172
required this.child,
179173
this.floatingActionWidget,
@@ -336,12 +330,6 @@ class Showcase extends StatefulWidget {
336330
/// Default to `true`
337331
final bool showArrow;
338332

339-
/// Height of [container]
340-
final double? height;
341-
342-
/// Width of [container]
343-
final double? width;
344-
345333
/// The duration of time the bouncing animation of tooltip should last.
346334
///
347335
/// Default to [Duration(milliseconds: 2000)]

0 commit comments

Comments
 (0)