Merge pull request #93 from SimformSolutionsPvtLtd/fix/UNT-T28813_runtime_exception_on_recording_in_android

fix(UNT-T28813): runtime exception on recording in android

Author: mukesh-simform

android/src/main/java/com/audiowaveform/AudioRecorder.kt

@@ -20,6 +20,7 @@ private const val RECORD_AUDIO_REQUEST_CODE = 1001
 class AudioRecorder {
     private var permissions = arrayOf(Manifest.permission.RECORD_AUDIO)
     private var useLegacyNormalization = false
+    private var isRecording = false
 
     private fun isPermissionGranted(activity: Activity?): Int? {
         return activity?.let { ActivityCompat.checkSelfPermission(it, permissions[0]) }
@@ -122,18 +123,26 @@ class AudioRecorder {
 
     fun stopRecording(recorder: MediaRecorder?, path: String, promise: Promise) {
         try {
-            recorder?.apply {
-                stop()
-                reset()
-                release()
+            if (isRecording) {
+                recorder?.apply {
+                    stop()
+                    reset()
+                    release()
+                }
+                isRecording = false
+                val tempArrayForCommunication : MutableList<String> = mutableListOf()
+                val duration = getDuration(path)
+                tempArrayForCommunication.add(path)
+                tempArrayForCommunication.add(duration.toString())
+                promise.resolve(Arguments.fromList(tempArrayForCommunication))
+            } else {
+                promise.reject("Error", "Recorder is not recording or has already been stopped")
             }
-            val tempArrayForCommunication : MutableList<String> = mutableListOf()
-            val duration = getDuration(path)
-            tempArrayForCommunication.add(path)
-            tempArrayForCommunication.add(duration.toString())
-            promise.resolve(Arguments.fromList(tempArrayForCommunication))
         } catch (e: IllegalStateException) {
             Log.e(Constants.LOG_TAG, "Failed to stop recording",e)
+        } catch (e: RuntimeException) {
+            Log.e(Constants.LOG_TAG, "Runtime exception when stopping recording", e)
+            promise.reject("Error", "Runtime exception: ${e.message}")
         }
     }
 
@@ -156,10 +165,12 @@ class AudioRecorder {
             useLegacyNormalization = useLegacy
             recorder?.apply {
                 start()
+                isRecording = true
             }
             promise.resolve(true)
         } catch (e: IllegalStateException) {
             Log.e(Constants.LOG_TAG, "Failed to start recording")
+            isRecording = false
         }
     }
 

android/src/main/java/com/audiowaveform/AudioWaveformModule.kt

@@ -31,6 +31,7 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
     private var sampleRate: Int = 44100
     private var bitRate: Int = 128000
     private val handler = Handler(Looper.getMainLooper())
+    private var startTime: Long = 0
 
     companion object {
         const val NAME = "AudioWaveform"
@@ -80,6 +81,7 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
         initRecorder(obj, promise)
         val useLegacyNormalization = true
         audioRecorder.startRecorder(recorder, useLegacyNormalization, promise)
+        startTime = System.currentTimeMillis() // Initialize startTime
         startEmittingRecorderValue()
     }
 
@@ -104,10 +106,21 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
             return
         }
 
-        audioRecorder.stopRecording(recorder, path!!, promise)
-        stopEmittingRecorderValue()
-        recorder = null
-        path = null
+        try {
+            val currentTime = System.currentTimeMillis()
+            if (currentTime - startTime < 500) {
+                promise.reject("SHORT_RECORDING", "Recording is too short")
+                return
+            }
+
+            stopEmittingRecorderValue()
+            audioRecorder.stopRecording(recorder, path!!, promise)
+            recorder = null
+            path = null
+        }   catch (e: Exception) {
+            Log.e(Constants.LOG_TAG, "Failed to stop recording", e)
+            promise.reject("Error", "Failed to stop recording: ${e.message}")
+        }
     }
 
     @ReactMethod