fix: 🔨Fixed PR comments

Author: Sahil-Simform

lib/src/constants.dart

@@ -1,5 +1,7 @@
 import 'package:flutter/material.dart';
 
+import 'widget/showcase_circular_progress_indecator.dart';
+
 class Constants {
   Constants._();
 
@@ -34,10 +36,9 @@ class Constants {
     borderRadius: BorderRadius.all(Radius.circular(8)),
   );
 
+  static const double cupertinoActivityIndicatorRadius = 12.0;
   static const Widget defaultProgressIndicator =
-      CircularProgressIndicator.adaptive(
-    backgroundColor: Colors.white,
-  );
+      ShowcaseCircularProgressIndicator();
 
   static const Duration defaultAnimationDuration = Duration(milliseconds: 2000);
 }

lib/src/get_position.dart

@@ -32,7 +32,7 @@ class GetPosition {
     this.padding = EdgeInsets.zero,
     this.rootRenderObject,
   }) {
-    _getRenderBox();
+    _getRenderBoxOffset();
   }
 
   final RenderBox? renderBox;
@@ -43,7 +43,7 @@ class GetPosition {
 
   Offset? _boxOffset;
 
-  void _getRenderBox() {
+  void _getRenderBoxOffset() {
     if (renderBox == null) return;
 
     _boxOffset = renderBox?.localToGlobal(

lib/src/layout_overlays.dart

@@ -46,6 +46,13 @@ class OverlayBuilder extends StatefulWidget {
 
   final WidgetBuilder? overlayBuilder;
   final Widget child;
+
+  /// A callback that provides a way to control the overlay visibility from
+  /// showcase widget
+  /// Basically we pass a reference to [_updateOverlay] function to parent so we
+  /// can call this from parent class to update the overlay
+  /// This callback provides a function that can be called with a boolean
+  /// parameter to show (true) or hide (false) the overlay.
   final ValueSetter<ValueSetter<bool>> updateOverlay;
 
   @override
@@ -141,7 +148,5 @@ class _OverlayBuilderState extends State<OverlayBuilder> {
   }
 
   @override
-  Widget build(BuildContext context) {
-    return widget.child;
-  }
+  Widget build(BuildContext context) => widget.child;
 }

lib/src/models/linked_showcase_data.dart

@@ -14,4 +14,22 @@ class LinkedShowcaseDataModel {
   final EdgeInsets overlayPadding;
   final BorderRadius? radius;
   final bool isCircle;
+
+  @override
+  bool operator ==(Object other) =>
+      identical(this, other) ||
+      other is LinkedShowcaseDataModel &&
+          runtimeType == other.runtimeType &&
+          rect == other.rect &&
+          radius == other.radius &&
+          overlayPadding == other.overlayPadding &&
+          isCircle == other.isCircle;
+
+  @override
+  int get hashCode => Object.hash(
+        rect,
+        radius,
+        overlayPadding,
+        isCircle,
+      );
 }

lib/src/shape_clipper.dart

@@ -22,6 +22,7 @@
 
 import 'dart:ui' as ui;
 
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 
 import 'constants.dart';
@@ -108,5 +109,5 @@ class RRectClipper extends CustomClipper<ui.Path> {
       radius != oldClipper.radius ||
       overlayPadding != oldClipper.overlayPadding ||
       area != oldClipper.area ||
-      linkedObjectData != oldClipper.linkedObjectData;
+      !listEquals(linkedObjectData, oldClipper.linkedObjectData);
 }