Skip to content

Commit 5ec26c4

Browse files
chore!: 🔥 Remove height and width requirement in Showcase.withWidget
1 parent b38990d commit 5ec26c4

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@
4141
Update deprecated `ShowCaseWidget` removal version.
4242
- Improvement [#505](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/505) -
4343
Fixed example app to run in flutter version `v3.32.5`.
44+
- Breaking [#541](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/541) -
45+
Removed height and width from `Showcase.withWidget` constructor, as it is not required anymore.
46+
- Improvement [#555](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/555)
47+
Expose `onFinish` callback via ShowCaseView.get.
4448
- Fixed [#564](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/564) -
4549
Apply textScaler to tooltip widgets.
4650
- Improvement [#570](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/570) -

example/lib/main.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,8 +590,6 @@ class MailTile extends StatelessWidget {
590590
if (showCaseDetail)
591591
Showcase.withWidget(
592592
key: showCaseKey!,
593-
height: 50,
594-
width: 150,
595593
tooltipActionConfig: const TooltipActionConfig(
596594
alignment: MainAxisAlignment.spaceBetween,
597595
crossAxisAlignment: CrossAxisAlignment.center,

lib/src/showcase/showcase.dart

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ class Showcase extends StatefulWidget {
112112
this.enableAutoScroll,
113113
this.floatingActionWidget,
114114
this.targetTooltipGap = 10,
115-
}) : height = null,
116-
width = null,
117-
container = null,
115+
}) : container = null,
118116
showcaseKey = key,
119117
assert(
120118
title != null || description != null,
@@ -157,8 +155,6 @@ class Showcase extends StatefulWidget {
157155
/// ```dart
158156
/// Showcase.withWidget(
159157
/// key: _customKey,
160-
/// height: 80,
161-
/// width: 140,
162158
/// container: Column(
163159
/// children: [
164160
/// Text(
@@ -177,8 +173,6 @@ class Showcase extends StatefulWidget {
177173
/// ```
178174
const Showcase.withWidget({
179175
required GlobalKey key,
180-
required this.height,
181-
required this.width,
182176
required this.container,
183177
required this.child,
184178
this.floatingActionWidget,
@@ -346,12 +340,6 @@ class Showcase extends StatefulWidget {
346340
/// Default to `true`
347341
final bool showArrow;
348342

349-
/// Height of [container]
350-
final double? height;
351-
352-
/// Width of [container]
353-
final double? width;
354-
355343
/// The duration of time the bouncing animation of tooltip should last.
356344
///
357345
/// Default to [Duration(milliseconds: 2000)]

0 commit comments

Comments
 (0)