Skip to content

Commit 75fccc6

Browse files
committed
better error when null cant be converted
1 parent 2111556 commit 75fccc6

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project>
33
<PropertyGroup>
44
<NoWarn>CS1591;NU5104;CS1573;CS9107;NU1608;NU1109</NoWarn>
5-
<Version>31.0.0</Version>
5+
<Version>31.0.1</Version>
66
<LangVersion>preview</LangVersion>
77
<AssemblyVersion>1.0.0</AssemblyVersion>
88
<PackageTags>EntityFrameworkCore, EntityFramework, GraphQL</PackageTags>

src/GraphQL.EntityFramework/Where/TypeConverter.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,11 @@ static List<T> GetEnumList<T>(IEnumerable<string> values)
203203
type = underlyingType;
204204
}
205205

206+
if (value is null)
207+
{
208+
throw new($"Expected value to be convertible to {type}. However it was null. It is possible a required variable was not provided");
209+
}
210+
206211
if (type == typeof(DateTime))
207212
{
208213
return ValueConverter.ConvertTo<DateTime>(value);
@@ -225,12 +230,12 @@ static List<T> GetEnumList<T>(IEnumerable<string> values)
225230

226231
if (type == typeof(Guid))
227232
{
228-
return new Guid(value!);
233+
return new Guid(value);
229234
}
230235

231236
if (type.IsEnum)
232237
{
233-
return Enum.Parse(type, value!, true);
238+
return Enum.Parse(type, value, true);
234239
}
235240

236241
return Convert.ChangeType(value, type);

0 commit comments

Comments
 (0)