.

Author: SimonCropp

assemblySize.include.md

@@ -28,23 +28,23 @@
 
 |                | Empty Assembly | With Polyfill | Diff      | Ensure    | ArgumentExceptions | StringInterpolation | Nullability |
 |----------------|----------------|---------------|-----------|-----------|--------------------|---------------------|-------------|
-| netstandard2.0 |         8.0 KB |      292.5 KB | +284.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| netstandard2.1 |         8.5 KB |      238.1 KB | +229.6 KB |  +15.9 KB |            +6.5 KB |            +14.8 KB |    +19.4 KB |
-| net461         |         5.5 KB |      298.0 KB | +292.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| net462         |         5.5 KB |      298.0 KB | +292.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| net47          |         5.5 KB |      297.7 KB | +292.2 KB |  +16.4 KB |            +7.0 KB |            +14.8 KB |    +19.9 KB |
-| net471         |         5.5 KB |      297.7 KB | +292.2 KB |  +16.4 KB |            +7.0 KB |            +14.8 KB |    +19.9 KB |
-| net472         |         5.5 KB |      295.0 KB | +289.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| net48          |         5.5 KB |      295.0 KB | +289.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| net481         |         5.5 KB |      295.0 KB | +289.5 KB |  +16.4 KB |            +7.0 KB |            +15.3 KB |    +19.9 KB |
-| netcoreapp2.0  |         9.0 KB |      263.8 KB | +254.8 KB |  +16.4 KB |            +6.5 KB |            +14.8 KB |    +19.9 KB |
-| netcoreapp2.1  |         9.0 KB |      251.9 KB | +242.9 KB |  +15.9 KB |            +6.5 KB |            +14.8 KB |    +19.4 KB |
-| netcoreapp2.2  |         9.0 KB |      251.9 KB | +242.9 KB |  +15.9 KB |            +6.5 KB |            +14.8 KB |    +19.4 KB |
-| netcoreapp3.0  |         9.5 KB |      237.8 KB | +228.3 KB |  +16.4 KB |            +6.5 KB |            +14.8 KB |    +19.9 KB |
-| netcoreapp3.1  |         9.5 KB |      236.3 KB | +226.8 KB |  +16.4 KB |            +6.5 KB |            +14.8 KB |    +19.4 KB |
-| net5.0         |         9.5 KB |      200.9 KB | +191.4 KB |  +16.4 KB |            +6.5 KB |            +14.8 KB |    +19.4 KB |
-| net6.0         |        10.0 KB |      155.5 KB | +145.5 KB |  +16.9 KB |            +7.0 KB |             +2.0 KB |     +4.5 KB |
-| net7.0         |        10.0 KB |      119.8 KB | +109.8 KB |  +16.9 KB |            +6.4 KB |             +2.5 KB |     +4.5 KB |
-| net8.0         |         9.5 KB |       93.1 KB |  +83.6 KB |  +16.4 KB |            +1.9 KB |             +2.5 KB |     +4.5 KB |
-| net9.0         |        10.0 KB |       52.6 KB |  +42.6 KB |  +16.9 KB |            +1.9 KB |             +2.5 KB |     +5.0 KB |
-| net10.0        |        10.0 KB |       38.7 KB |  +28.7 KB |  +17.4 KB |            +2.4 KB |             +2.5 KB |     +5.0 KB |
+| netstandard2.0 |         8.0 KB |      290.7 KB | +282.7 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| netstandard2.1 |         8.5 KB |      236.6 KB | +228.1 KB |  +15.8 KB |            +6.5 KB |            +14.8 KB |    +19.3 KB |
+| net461         |         5.5 KB |      296.2 KB | +290.7 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| net462         |         5.5 KB |      296.2 KB | +290.7 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| net47          |         5.5 KB |      296.0 KB | +290.5 KB |  +16.3 KB |            +7.0 KB |            +14.8 KB |    +19.8 KB |
+| net471         |         5.5 KB |      296.0 KB | +290.5 KB |  +16.3 KB |            +7.0 KB |            +14.8 KB |    +19.8 KB |
+| net472         |         5.5 KB |      293.3 KB | +287.8 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| net48          |         5.5 KB |      293.3 KB | +287.8 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| net481         |         5.5 KB |      293.3 KB | +287.8 KB |  +16.3 KB |            +7.0 KB |            +15.3 KB |    +19.8 KB |
+| netcoreapp2.0  |         9.0 KB |      262.2 KB | +253.2 KB |  +16.3 KB |            +6.5 KB |            +14.8 KB |    +19.8 KB |
+| netcoreapp2.1  |         9.0 KB |      250.3 KB | +241.3 KB |  +15.8 KB |            +6.5 KB |            +14.8 KB |    +19.3 KB |
+| netcoreapp2.2  |         9.0 KB |      250.3 KB | +241.3 KB |  +15.8 KB |            +6.5 KB |            +14.8 KB |    +19.3 KB |
+| netcoreapp3.0  |         9.5 KB |      236.4 KB | +226.9 KB |  +16.3 KB |            +6.5 KB |            +14.8 KB |    +19.8 KB |
+| netcoreapp3.1  |         9.5 KB |      234.8 KB | +225.3 KB |  +16.3 KB |            +6.5 KB |            +14.8 KB |    +19.3 KB |
+| net5.0         |         9.5 KB |      199.7 KB | +190.2 KB |  +16.3 KB |            +6.5 KB |            +14.8 KB |    +19.3 KB |
+| net6.0         |        10.0 KB |      154.5 KB | +144.5 KB |  +16.8 KB |            +7.0 KB |             +2.0 KB |     +4.5 KB |
+| net7.0         |        10.0 KB |      119.0 KB | +109.0 KB |  +16.7 KB |            +6.4 KB |             +2.5 KB |     +4.5 KB |
+| net8.0         |         9.5 KB |       92.4 KB |  +82.9 KB |  +16.3 KB |            +1.8 KB |             +2.5 KB |     +4.5 KB |
+| net9.0         |        10.0 KB |       52.1 KB |  +42.1 KB |  +16.8 KB |            +1.9 KB |             +2.5 KB |     +5.0 KB |
+| net10.0        |        10.0 KB |       38.3 KB |  +28.3 KB |  +17.3 KB |            +2.4 KB |             +2.5 KB |     +5.0 KB |

src/ApiBuilderTests/FrameworkSplitterTest.cs

@@ -90,6 +90,10 @@ void ProcessFile(string sourceFile, FrameworkIdentifier framework, string framew
         var processedCode = processedRoot.ToFullString();
         // Normalize line endings to LF, then use consistent line endings throughout
         processedCode = processedCode.Replace("\r\n", "\n").Replace("\r", "\n");
+        // Remove //Link: comment lines (they may be inside DisabledTextTrivia that wasn't processed)
+        var lines = processedCode.Split('\n');
+        var filteredLines = lines.Where(line => !line.TrimStart().StartsWith("//Link:", StringComparison.OrdinalIgnoreCase));
+        processedCode = string.Join("\n", filteredLines);
         var codeWithHeader = $"// <auto-generated />\n#pragma warning disable\n{processedCode}";
         File.WriteAllText(outputPath, codeWithHeader);
 

src/Split/net10.0/ArgumentExceptions/ArgumentNullExceptionPolyfill.cs

@@ -12,7 +12,6 @@ static partial class Polyfill
     {
 
 #if AllowUnsafeBlocks && !NET9_0_OR_GREATER
-        //Link: https://learn.microsoft.com/en-us/dotnet/api/system.argumentnullexception.throwifnull?view=net-10.0#system-argumentnullexception-throwifnull(system-void*-system-string)
         public static unsafe void ThrowIfNull(void* argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
         {
             if (argument is null)

src/Split/net10.0/Regex/RegexPolyfill.cs

@@ -20,21 +20,18 @@ static partial class Polyfill
 
 #if !NET9_0_OR_GREATER && FeatureMemory && FeatureValueTuple
 
-        //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.enumeratesplits?view=net-10.0#system-text-regularexpressions-regex-enumeratesplits(system-readonlyspan((system-char))-system-string)
         public static ValueSplitEnumerator EnumerateSplits(ReadOnlySpan<char> input, string pattern)
         {
             var regex = new Regex(pattern);
             return new ValueSplitEnumerator(input, regex, 0, 0);
         }
 
-        //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.enumeratesplits?view=net-10.0#system-text-regularexpressions-regex-enumeratesplits(system-readonlyspan((system-char))-system-string-system-text-regularexpressions-regexoptions)
         public static ValueSplitEnumerator EnumerateSplits(ReadOnlySpan<char> input, string pattern, RegexOptions options)
         {
             var regex = new Regex(pattern, options);
             return new ValueSplitEnumerator(input, regex, 0, 0);
         }
 
-        //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.enumeratesplits?view=net-10.0#system-text-regularexpressions-regex-enumeratesplits(system-readonlyspan((system-char))-system-string-system-text-regularexpressions-regexoptions-system-timespan)
         public static ValueSplitEnumerator EnumerateSplits(ReadOnlySpan<char> input, string pattern, RegexOptions options, TimeSpan matchTimeout)
         {
             var regex = new Regex(pattern, options, matchTimeout);

src/Split/net10.0/StringInterpolation/Polyfill_StringBuilder_Append.cs

@@ -10,14 +10,12 @@ static partial class Polyfill
 {
 #if FeatureMemory && !NET6_0_OR_GREATER
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))]
         ref AppendInterpolatedStringHandler handler) => target;
 
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         IFormatProvider? provider,

src/Split/net10.0/StringInterpolation/Polyfill_StringBuilder_AppendLine.cs

@@ -11,15 +11,13 @@ static partial class Polyfill
 #if FeatureMemory && !NET6_0_OR_GREATER
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))]
         ref AppendInterpolatedStringHandler handler) =>
         target.AppendLine();
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         IFormatProvider? provider,

src/Split/net461/StringInterpolation/Polyfill_StringBuilder_Append.cs

@@ -27,14 +27,12 @@ public static StringBuilder Append(
 #elif NET6_0_OR_GREATER
 
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))] ref StringBuilder.AppendInterpolatedStringHandler handler) =>
         target.Append(ref handler);
 
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         IFormatProvider? provider,

src/Split/net461/StringInterpolation/Polyfill_StringBuilder_AppendLine.cs

@@ -30,15 +30,13 @@ public static StringBuilder AppendLine(
 #elif NET6_0_OR_GREATER
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))]
         ref StringBuilder.AppendInterpolatedStringHandler handler) =>
         target.AppendLine(ref handler);
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         IFormatProvider? provider,

src/Split/net462/StringInterpolation/Polyfill_StringBuilder_Append.cs

@@ -27,14 +27,12 @@ public static StringBuilder Append(
 #elif NET6_0_OR_GREATER
 
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))] ref StringBuilder.AppendInterpolatedStringHandler handler) =>
         target.Append(ref handler);
 
     /// <summary>Appends the specified interpolated string to this instance.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.append?view=net-10.0#system-text-stringbuilder-append(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder Append(
         StringBuilder target,
         IFormatProvider? provider,

src/Split/net462/StringInterpolation/Polyfill_StringBuilder_AppendLine.cs

@@ -30,15 +30,13 @@ public static StringBuilder AppendLine(
 #elif NET6_0_OR_GREATER
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         [InterpolatedStringHandlerArgument(nameof(target))]
         ref StringBuilder.AppendInterpolatedStringHandler handler) =>
         target.AppendLine(ref handler);
 
     /// <summary>Appends the specified interpolated string followed by the default line terminator to the end of the current StringBuilder object.</summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendline?view=net-10.0#system-text-stringbuilder-appendline(system-iformatprovider-system-text-stringbuilder-appendinterpolatedstringhandler@)
     public static StringBuilder AppendLine(
         StringBuilder target,
         IFormatProvider? provider,