Add Stream.Write(ReadOnlySpan<byte>) (#487)

* Add  Stream.Write(ReadOnlySpan<byte>)

* Update PolyfillTests_Stream.cs

* Update Directory.Build.props

Author: SimonCropp

TestResults/ApiBuilderTests-windows-net11.0-report.html

@@ -1 +1 @@
-**API count: 748**
+**API count: 749**

TestResults/Tests-windows-net10.0-report.html

@@ -787,6 +787,7 @@
  * `void ReadExactly(Span<byte>)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactly?view=net-11.0#system-io-stream-readexactly(system-span((system-byte))))
  * `ValueTask ReadExactlyAsync(byte[], int, int, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactlyasync?view=net-11.0#system-io-stream-readexactlyasync(system-byte()-system-int32-system-int32-system-threading-cancellationtoken))
  * `ValueTask ReadExactlyAsync(Memory<byte>, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactlyasync?view=net-11.0#system-io-stream-readexactlyasync(system-memory((system-byte))-system-threading-cancellationtoken))
+ * `void Write(ReadOnlySpan<byte>)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.write?view=net-11.0#system-io-stream-write(system-readonlyspan((system-byte))))
  * `ValueTask WriteAsync(ReadOnlyMemory<byte>, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.writeasync?view=net-11.0#system-io-stream-writeasync(system-readonlymemory((system-byte))-system-threading-cancellationtoken))
 
 

TestResults/Tests-windows-net48-report.html

@@ -13,7 +13,7 @@ The package targets `netstandard2.0` and is designed to support the following ru
  * `uap10`
 
 
-**API count: 748**<!-- singleLineInclude: apiCount. path: /apiCount.include.md -->
+**API count: 749**<!-- singleLineInclude: apiCount. path: /apiCount.include.md -->
 
 
 **See [Milestones](../../milestones?state=closed) for release notes.**
@@ -1290,6 +1290,7 @@ The class `Polyfill` includes the following extension methods:
  * `void ReadExactly(Span<byte>)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactly?view=net-11.0#system-io-stream-readexactly(system-span((system-byte))))
  * `ValueTask ReadExactlyAsync(byte[], int, int, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactlyasync?view=net-11.0#system-io-stream-readexactlyasync(system-byte()-system-int32-system-int32-system-threading-cancellationtoken))
  * `ValueTask ReadExactlyAsync(Memory<byte>, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactlyasync?view=net-11.0#system-io-stream-readexactlyasync(system-memory((system-byte))-system-threading-cancellationtoken))
+ * `void Write(ReadOnlySpan<byte>)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.write?view=net-11.0#system-io-stream-write(system-readonlyspan((system-byte))))
  * `ValueTask WriteAsync(ReadOnlyMemory<byte>, CancellationToken)` [reference](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.writeasync?view=net-11.0#system-io-stream-writeasync(system-readonlymemory((system-byte))-system-threading-cancellationtoken))
 
 

apiCount.include.md

@@ -648,7 +648,7 @@ void File_Methods()
         using var nullHandle = File.OpenNullHandle();
 #endif
 
-        FileSystemInfo hardLink = File.CreateHardLink("hardlink.txt", TestFilePath);
+        var hardLink = File.CreateHardLink("hardlink.txt", TestFilePath);
         var fileInfo = new FileInfo("hardlink2.txt");
         fileInfo.CreateAsHardLink(TestFilePath);
     }
@@ -1005,6 +1005,9 @@ async Task Stream_Methods()
         var input = new byte[] {1, 2};
         using var stream = new MemoryStream(input);
         var result = new byte[2];
+#if FeatureMemory
+        ((Stream)stream).Write((ReadOnlySpan<byte>)input);
+#endif
 #if FeatureMemory && FeatureValueTask
         var memory = new Memory<byte>(result);
         var read = await stream.ReadAsync(memory);

api_list.include.md

@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;NETSDK1138;NU1901;NU1902;NU1903;CA1822;CA1847;CA1861;NU1510;NU1608;NU1109</NoWarn>
-    <Version>9.13.0</Version>
+    <Version>9.14.0</Version>
     <AssemblyVersion>1.0.0</AssemblyVersion>
     <PackageTags>Polyfill</PackageTags>
     <DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>

readme.md

@@ -3,54 +3,12 @@ namespace Polyfills;
 // ReSharper disable once RedundantUsingDirective
 using System;
 using System.IO;
-using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 
 static partial class Polyfill
 {
 #if !NETCOREAPP2_1_OR_GREATER && !NETSTANDARD2_1_OR_GREATER
-#if FeatureMemory && FeatureValueTask
-
-    /// <summary>
-    /// Asynchronously reads a sequence of bytes from the current stream, advances the position within the stream by
-    /// the number of bytes read, and monitors cancellation requests.
-    /// </summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readasync?view=net-11.0#system-io-stream-readasync(system-memory((system-byte))-system-threading-cancellationtoken)
-    public static ValueTask<int> ReadAsync(
-        this Stream target,
-        Memory<byte> buffer,
-        CancellationToken cancellationToken = default)
-    {
-        if (!MemoryMarshal.TryGetArray((ReadOnlyMemory<byte>) buffer, out var segment))
-        {
-            segment = new(buffer.ToArray());
-        }
-
-        var task = target.ReadAsync(segment.Array!, segment.Offset, segment.Count, cancellationToken);
-        return new(task);
-    }
-
-    /// <summary>
-    /// Asynchronously writes a sequence of bytes to the current stream, advances the current position
-    /// within this stream by the number of bytes written, and monitors cancellation requests.
-    /// </summary>
-    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.writeasync?view=net-11.0#system-io-stream-writeasync(system-readonlymemory((system-byte))-system-threading-cancellationtoken)
-    public static ValueTask WriteAsync(
-        this Stream target,
-        ReadOnlyMemory<byte> buffer,
-        CancellationToken cancellationToken = default)
-    {
-        if (!MemoryMarshal.TryGetArray(buffer, out var segment))
-        {
-            segment = new(buffer.ToArray());
-        }
-
-        var task = target.WriteAsync(segment.Array!, segment.Offset, segment.Count, cancellationToken);
-        return new(task);
-    }
-
-#endif
 
     /// <summary>
     /// Asynchronously reads the bytes from the current stream and writes them to another stream, using a specified

src/Consume/Consume.cs

@@ -3,12 +3,37 @@ namespace Polyfills;
 using System;
 using System.IO;
 // ReSharper disable RedundantUsingDirective
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 // ReSharper restore RedundantUsingDirective
 
 static partial class Polyfill
 {
+#if !NETCOREAPP2_1_OR_GREATER && !NETSTANDARD2_1_OR_GREATER
+#if FeatureMemory && FeatureValueTask
+
+    /// <summary>
+    /// Asynchronously reads a sequence of bytes from the current stream, advances the position within the stream by
+    /// the number of bytes read, and monitors cancellation requests.
+    /// </summary>
+    //Link: https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readasync?view=net-11.0#system-io-stream-readasync(system-memory((system-byte))-system-threading-cancellationtoken)
+    public static ValueTask<int> ReadAsync(
+        this Stream target,
+        Memory<byte> buffer,
+        CancellationToken cancellationToken = default)
+    {
+        if (!MemoryMarshal.TryGetArray((ReadOnlyMemory<byte>) buffer, out var segment))
+        {
+            segment = new(buffer.ToArray());
+        }
+
+        var task = target.ReadAsync(segment.Array!, segment.Offset, segment.Count, cancellationToken);
+        return new(task);
+    }
+
+#endif
+#endif
 #if !NETCOREAPP2_1_OR_GREATER && !NETSTANDARD2_1 && FeatureMemory
     /// <summary>
     /// Reads a sequence of bytes from the current stream and advances the position within the stream by the number of bytes read.