Merge pull request #279 from SimonHalvdansson/codex/implement-fallback-for-null-favicon-in-coil

Add Coil fallback for missing favicons

Author: SimonHalvdansson

app/src/main/java/com/simon/harmonichackernews/network/FaviconLoader.java

@@ -1,6 +1,7 @@
 package com.simon.harmonichackernews.network;
 
 import android.content.Context;
+import android.graphics.drawable.Drawable;
 import android.widget.ImageView;
 
 import androidx.core.content.ContextCompat;
@@ -19,11 +20,14 @@ public static void loadFavicon(String url, ImageView into, Context ctx, String f
         try {
             String host = Utils.getDomainName(url);
             int faviconSize = Utils.pxFromDpInt(ctx.getResources(), 17);
+            Drawable webDrawable = Objects.requireNonNull(ContextCompat.getDrawable(ctx, R.drawable.ic_action_web));
 
             ImageRequest request = new ImageRequest.Builder(ctx)
                     .data(getFaviconUrl(host, faviconProvider))
                     .size(faviconSize, faviconSize)
-                    .placeholder(Objects.requireNonNull(ContextCompat.getDrawable(ctx, R.drawable.ic_action_web)))
+                    .placeholder(webDrawable)
+                    .error(webDrawable)
+                    .fallback(webDrawable)
                     .target(into)
                     .build();