Skip to content

Commit de98424

Browse files
MMelQinSimoneBendazzoli93
authored andcommitted
Editorial changes to correct typos, rename parameters, and add comments (Project-MONAI#526)
* Editorial changes to correct typos, rename parameters, adding comments. Retested examples. Signed-off-by: M Q <[email protected]> * More editorial changes covering the whole repo Signed-off-by: M Q <[email protected]> * Fix flake8 complaint Signed-off-by: M Q <[email protected]> * Fix flake8 complaints Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
1 parent 7e790bf commit de98424

File tree

32 files changed

+99
-93
lines changed

32 files changed

+99
-93
lines changed

docs/_static/custom.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ blockquote p {
107107
}
108108

109109
/* Mermaid
110-
to avoid the lable text being cut off
110+
to avoid the label text being cut off
111111
*/
112112
.edgeTerminals {
113113
font-size: 9px !important;

docs/source/developing_with_sdk/packaging_app.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ It is required that the application configuration yaml file as well as the depen
1313
### Basic Usage of MONAI Application Packager
1414

1515
```bash
16-
monai-deploy package <APP_PATH> --config <COMFIG> --tag <TAG> --platform <x64-workstation> [--models <MODEL_PATH>] [--log-level <LEVEL>] [-h]
16+
monai-deploy package <APP_PATH> --config <CONFIG> --tag <TAG> --platform <x64-workstation> [--models <MODEL_PATH>] [--log-level <LEVEL>] [-h]
1717
```
1818

1919
#### Required Arguments

docs/source/getting_started/tutorials/mednist_app.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jupyter-lab
4242
<div style="text-align: center;">
4343
<iframe width="560" height="315" src="https://www.youtube.com/embed/WwjilJFHuU4" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
4444
45-
<p>Video may show the use of previous SDK verson.</p>
45+
<p>Video may show the use of previous SDK version.</p>
4646
</div>
4747
```
4848

docs/source/getting_started/tutorials/monai_bundle_app.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jupyter-lab
3232
<div style="text-align: center;">
3333
<iframe width="560" height="315" src="https://www.youtube.com/embed/nivgfD4pwWE" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
3434
35-
<p>Video may show the use of previous SDK verson.</p>
35+
<p>Video may show the use of previous SDK version.</p>
3636
</div>
3737
```
3838

docs/source/release_notes/v0.3.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This operator uses [Clara Viz](https://pypi.org/project/clara-viz/) to provide i
1616

1717
### STL Surface Mesh Conversion Operator
1818

19-
This operator converts a volume image to surface mesh, in [STL file format](https://en.wikipedia.org/wiki/STL_(file_format)). Its API allows the client to control if smoothing needs to be applied, and if only keeping the largest connected component; the latter is useful when muliple disjoint segments are in a volume image, and the application needs to control if all or only the largest to be included in the output.
19+
This operator converts a volume image to surface mesh, in [STL file format](https://en.wikipedia.org/wiki/STL_(file_format)). Its API allows the client to control if smoothing needs to be applied, and if only keeping the largest connected component; the latter is useful when multiple disjoint segments are in a volume image, and the application needs to control if all or only the largest to be included in the output.
2020

2121
## What's fixed/updated
2222

docs/source/release_notes/v0.4.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
The new operator, `MONAI Bundle Inference Operator`, is intended to automate the inference with a MONAI Bundle in TorchScript with the following functionalities:
1111
- Parse the model metadata and extra configuration data in the TorchScript file
12-
- Instanciate MONAI transforms and inferer objects per bundle configuration data
12+
- Instantiate MONAI transforms and inferer objects per bundle configuration data
1313
- Convert input/output of the operator to and from model network input
1414
- Support named model and can be used in a multi-model application
1515

docs/source/release_notes/v0.5.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- Generated DICOM instances as AI evidence now have the attribute <a href="https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.12.html#table_C.12-1">(0008,0201) Timezone Offset From UTC</a>, in addition to the DICOM date and time which are set with values from the underlying operating system. The OS is expected to be synchronized with a known good timing source and have the correct timezone setting
88
- Generated DICOM instance file names are now based on the SOP instance UID
99
- Support DICOM instance level attribute matching in the DICOM Series Selection Operator
10-
- Operators and example applications are verified to be re-runable without needing to reinitialize the application object or re-load the AI model network. This will allow a main function or an external script to instantiate the application object once and use it to process multiple discreet inputs, either in a batch processing mode or in a long running service
10+
- Operators and example applications are verified to be re-runable without needing to reinitialize the application object or re-load the AI model network. This will allow a main function or an external script to instantiate the application object once and use it to process multiple discrete inputs, either in a batch processing mode or in a long running service
1111
- Tutorials, in Jupyter notebooks, are re-organized and updated
1212
- Reference added for <a href="https://github.com/Project-MONAI/monai-deploy/releases">MONAI Deploy Express</a> for hosting MAPs in development environments
1313
- Removed is the reference to the deprecated MONAI Inference Service

docs/srs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ The SDK shall allow the packaging of the application in a standardized format so
521521

522522
### Background
523523

524-
Please refer to [MONAI Application Packge Spec](https://github.com/Project-MONAI/monai-deploy-experimental/blob/main/guidelines/monai-application-package.md)for details.
524+
Please refer to [MONAI Application Package Spec](https://github.com/Project-MONAI/monai-deploy-experimental/blob/main/guidelines/monai-application-package.md)for details.
525525

526526
### Verification Strategy
527527

examples/apps/ai_unetr_seg_app/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def compose(self):
8080
_algorithm_family = codes.DCM.ArtificialIntelligence
8181
_algorithm_version = "0.1.0"
8282

83-
# List of (Segment name, [Code menaing str]), not including background which is value of 0.
83+
# List of (Segment name, [Code meaning str]), not including background which is value of 0.
8484
# User must provide correct codes, which can be looked at, e.g.
8585
# https://bioportal.bioontology.org/ontologies/SNOMEDCT
8686
# Alternatively, consult the concept and code dictionaries in PyDicom

examples/apps/ai_unetr_seg_app/unetr_seg_operator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class UnetrSegOperator(Operator):
5656

5757
def __init__(
5858
self,
59-
frament: Fragment,
59+
fragment: Fragment,
6060
*args,
6161
app_context: AppContext,
6262
model_path: Path,
@@ -71,13 +71,13 @@ def __init__(
7171
self.model_path = model_path
7272
self.output_folder = output_folder
7373
self.output_folder.mkdir(parents=True, exist_ok=True)
74-
self.fragement = frament # Cache and later pass the Fragment/Application to contained operator(s)
74+
self.app_fragment = fragment # Cache and later pass the Fragment/Application to contained operator(s)
7575
self.app_context = app_context
7676
self.input_name_image = "image"
7777
self.output_name_seg = "seg_image"
7878
self.output_name_saved_images_folder = "saved_images_folder"
7979

80-
super().__init__(frament, *args, **kwargs)
80+
super().__init__(fragment, *args, **kwargs)
8181

8282
def setup(self, spec: OperatorSpec):
8383
spec.input(self.input_name_image)
@@ -102,7 +102,7 @@ def compute(self, op_input, op_output, context):
102102

103103
# Delegates inference and saving output to the built-in operator.
104104
infer_operator = MonaiSegInferenceOperator(
105-
self.fragement,
105+
self.app_fragment,
106106
roi_size=(
107107
96,
108108
96,

0 commit comments

Comments
 (0)