Replace use of const std::string & to string_view

Author: ManifoldFR

examples/Ur5WithSystems.cpp

@@ -94,16 +94,16 @@ static void updateOrtho(float zoom) {
 }
 
 static std::shared_ptr<coal::ConvexBase>
-loadConvexMeshFromFile(const std::string &filename) {
+loadConvexMeshFromFile(std::string_view filename) {
   coal::NODE_TYPE bv_type = coal::BV_AABB;
   coal::MeshLoader load{bv_type};
-  coal::BVHModelPtr_t bvh = load.load(filename);
+  coal::BVHModelPtr_t bvh = load.load(std::string{filename});
   bvh->buildConvexHull(true, "Qt");
   return bvh->convex;
 }
 
 static pin::GeometryObject
-loadGeomObjFromFile(const char *name, const std::string &filename,
+loadGeomObjFromFile(const char *name, std::string_view filename,
                     pin::SE3 pl = pin::SE3::Identity()) {
   auto convex = loadConvexMeshFromFile(filename);
   Eigen::Vector3d scale;

src/candlewick/utils/VideoRecorder.cpp

@@ -50,7 +50,7 @@ namespace media {
     AVFrame *tmpFrame = nullptr;
     AVPacket *packet = nullptr;
 
-    VideoRecorderImpl(int width, int height, const std::string &filename,
+    VideoRecorderImpl(int width, int height, std::string_view filename,
                       VideoRecorder::Settings settings);
 
     VideoRecorderImpl(const VideoRecorderImpl &) = delete;
@@ -96,7 +96,7 @@ namespace media {
   }
 
   VideoRecorderImpl::VideoRecorderImpl(int width, int height,
-                                       const std::string &filename,
+                                       std::string_view filename,
                                        VideoRecorder::Settings settings)
       : m_width(width), m_height(height) {
 
@@ -111,7 +111,7 @@ namespace media {
     }
 
     int ret = avformat_alloc_output_context2(&formatContext, nullptr, nullptr,
-                                             filename.c_str());
+                                             filename.data());
     char errbuf[AV_ERROR_MAX_STRING_SIZE]{0};
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
@@ -150,7 +150,7 @@ namespace media {
       terminate_with_message("Couldn't open codec: %s", errbuf);
     }
 
-    ret = avio_open(&formatContext->pb, filename.c_str(), AVIO_FLAG_WRITE);
+    ret = avio_open(&formatContext->pb, filename.data(), AVIO_FLAG_WRITE);
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
       terminate_with_message("Couldn't open output stream: %s", errbuf);
@@ -229,18 +229,18 @@ namespace media {
   VideoRecorder &VideoRecorder::operator=(VideoRecorder &&) noexcept = default;
 
   VideoRecorder::VideoRecorder(Uint32 width, Uint32 height,
-                               const std::string &filename, Settings settings)
+                               std::string_view filename, Settings settings)
       : _width(width), _height(height) {
     this->settings = settings;
     this->open(width, height, filename);
   }
 
   VideoRecorder::VideoRecorder(Uint32 width, Uint32 height,
-                               const std::string &filename)
+                               std::string_view filename)
       : VideoRecorder(width, height, filename, Settings{}) {}
 
   void VideoRecorder::open(Uint32 width, Uint32 height,
-                           const std::string &filename) {
+                           std::string_view filename) {
     if (_impl)
       terminate_with_message("Recording stream already open.");
 

src/candlewick/utils/VideoRecorder.h

@@ -37,7 +37,7 @@ namespace media {
     VideoRecorder(VideoRecorder &&) noexcept;
     VideoRecorder &operator=(VideoRecorder &&) noexcept;
 
-    void open(Uint32 width, Uint32 height, const std::string &filename);
+    void open(Uint32 width, Uint32 height, std::string_view filename);
 
     bool isRecording() const { return _impl != nullptr; }
 
@@ -50,10 +50,10 @@ namespace media {
     ///
     /// \note If the settings' output dimensions are not set, they will
     /// automatically be set to be the input's dimensions.
-    VideoRecorder(Uint32 width, Uint32 height, const std::string &filename,
+    VideoRecorder(Uint32 width, Uint32 height, std::string_view filename,
                   Settings settings);
 
-    VideoRecorder(Uint32 width, Uint32 height, const std::string &filename);
+    VideoRecorder(Uint32 width, Uint32 height, std::string_view filename);
 
     Uint32 frameCounter() const;