Fix all calls to terminate_with_message() (format string with%)

Author: ManifoldFR

CHANGELOG.md

@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - core : fix `CommandBuffer::submitAndAcquireFence()` not setting the internal pointer to null
+- Fix all calls to `terminate_with_message()` (format string with `%`) (https://github.com/Simple-Robotics/candlewick/pull/62)
 
 ## [0.0.7] - 2025-05-17
 

src/candlewick/core/DepthAndShadowPass.cpp

@@ -37,7 +37,7 @@ DepthPass::DepthPass(const Device &device, const MeshLayout &layout,
   };
   pipeline = SDL_CreateGPUGraphicsPipeline(device, &pipeline_desc);
   if (!pipeline)
-    terminate_with_message("Failed to create graphics pipeline: %s.",
+    terminate_with_message("Failed to create graphics pipeline: {:s}.",
                            SDL_GetError());
 }
 

src/candlewick/multibody/RobotScene.cpp

@@ -226,7 +226,7 @@ void RobotScene::initCompositePipeline(const MeshLayout &layout) {
 
   pipelines.wboitComposite = SDL_CreateGPUGraphicsPipeline(device(), &desc);
   if (!pipelines.wboitComposite) {
-    terminate_with_message("Failed to create WBOIT pipeline: %s",
+    terminate_with_message("Failed to create WBOIT pipeline: {:s}",
                            SDL_GetError());
   }
 }

src/candlewick/multibody/RobotScene.h

@@ -27,7 +27,7 @@ template <typename T>
 [[noreturn]] void
 invalid_enum(const char *msg, T type,
              std::source_location location = std::source_location::current()) {
-  terminate_with_message(location, "Invalid enum: %s - %s", msg,
+  terminate_with_message(location, "Invalid enum: {:s} - {:s}", msg,
                          magic_enum::enum_name(type));
 }
 

src/candlewick/utils/LoadMaterial.cpp

@@ -90,8 +90,7 @@ PbrMaterial loadFromAssimpMaterial(aiMaterial *material) {
   if (retc == material_load_retc::OK)
     return pbrFromPhong(phong);
 
-  std::string msg = "Failed to load material: return code ";
-  msg += magic_enum::enum_name(retc);
-  terminate_with_message(msg);
+  terminate_with_message("Failed to load material: {:s}",
+                         magic_enum::enum_name(retc));
 }
 } // namespace candlewick

src/candlewick/utils/MeshData.h

@@ -109,7 +109,7 @@ class MeshData : public MeshDataBase<MeshData> {
       return this->getAttribute<T>(*attr);
     }
     terminate_with_message(
-        std::format("Vertex attribute %d not found.", Uint16(loc)));
+        std::format("Vertex attribute {:d} not found.", Uint16(loc)));
   }
 
   template <typename T>
@@ -118,7 +118,7 @@ class MeshData : public MeshDataBase<MeshData> {
       return this->getAttribute<T>(*attr);
     }
     terminate_with_message(
-        std::format("Vertex attribute %d not found.", Uint16(loc)));
+        std::format("Vertex attribute {:d} not found.", Uint16(loc)));
   }
 
   std::span<const char> vertexData() const { return m_vertexData; }

src/candlewick/utils/VideoRecorder.cpp

@@ -144,25 +144,25 @@ namespace media {
     ret = avcodec_parameters_from_context(videoStream->codecpar, codecContext);
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
-      terminate_with_message("Couldn't copy codec params: %s", errbuf);
+      terminate_with_message("Couldn't copy codec params: {:s}", errbuf);
     }
 
     ret = avcodec_open2(codecContext, codec, nullptr);
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
-      terminate_with_message("Couldn't open codec: %s", errbuf);
+      terminate_with_message("Couldn't open codec: {:s}", errbuf);
     }
 
     ret = avio_open(&formatContext->pb, filename.data(), AVIO_FLAG_WRITE);
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
-      terminate_with_message("Couldn't open output stream: %s", errbuf);
+      terminate_with_message("Couldn't open output stream: {:s}", errbuf);
     }
 
     ret = avformat_write_header(formatContext, nullptr);
     if (ret < 0) {
       av_strerror(ret, errbuf, AV_ERROR_MAX_STRING_SIZE);
-      terminate_with_message("Couldn't write output header: %s", errbuf);
+      terminate_with_message("Couldn't write output header: {:s}", errbuf);
     }
 
     packet = av_packet_alloc();
@@ -188,7 +188,7 @@ namespace media {
     ret = av_frame_make_writable(tmpFrame);
     if (ret < 0)
       terminate_with_message(
-          "Failed to make tmpFrame writable: %s",
+          "Failed to make tmpFrame writable: {:s}",
           av_make_error_string(errbuf, AV_ERROR_MAX_STRING_SIZE, ret));
 
     // copy input payload to tmp frame
@@ -198,7 +198,7 @@ namespace media {
     ret = av_frame_make_writable(frame);
     if (ret < 0) {
       terminate_with_message(
-          "Failed to make frame writable: %s",
+          "Failed to make frame writable: {:s}",
           av_make_error_string(errbuf, AV_ERROR_MAX_STRING_SIZE, ret));
     }
     frame->pts = m_frameCounter++;
@@ -209,7 +209,7 @@ namespace media {
     ret = avcodec_send_frame(codecContext, frame);
     if (ret < 0) {
       terminate_with_message(
-          "Error sending frame %s",
+          "Error sending frame {:s}",
           av_make_error_string(errbuf, AV_ERROR_MAX_STRING_SIZE, ret));
     }
 
@@ -220,7 +220,7 @@ namespace media {
       }
       if (ret < 0) {
         terminate_with_message(
-            "Error receiving packet from encoder: %s",
+            "Error receiving packet from encoder: {:s}",
             av_make_error_string(errbuf, AV_ERROR_MAX_STRING_SIZE, ret));
       }
 
@@ -274,7 +274,7 @@ namespace media {
     case SDL_GPU_TEXTUREFORMAT_R8G8B8A8_UNORM:
       return AV_PIX_FMT_RGBA;
     default:
-      terminate_with_message("Unsupported SDL GPU texture format %s",
+      terminate_with_message("Unsupported SDL GPU texture format {:s}",
                              magic_enum::enum_name(pixelFormat));
     }
   }

src/candlewick/utils/WriteTextureToImage.cpp

@@ -112,7 +112,7 @@ void saveTextureToFile(CommandBuffer &command_buffer, const Device &device,
 
   if (!ret)
     terminate_with_message(
-        "stbi_write_png() failed. Please check filename (%s)", filename);
+        "stbi_write_png() failed. Please check filename ({:s})", filename);
 
   if (rgba_pixels)
     std::free(rgba_pixels);