Remove some is_final()

ManifoldFR · ManifoldFR · commit 63c54cb2a70f · 2025-03-28T12:23:47.000+01:00
diff --git a/include/nanoeigenpy/solvers/conjugate-gradient.hpp b/include/nanoeigenpy/solvers/conjugate-gradient.hpp
@@ -26,8 +26,7 @@ struct ConjugateGradientVisitor
   }
 
   static void expose(nb::module_& m, const char* name) {
-    nb::class_<ConjugateGradient>(
-        m, name, nb::is_final())  // is_final good to replace bp::noncopyable ?
+    nb::class_<ConjugateGradient>(m, name)
         .def(ConjugateGradientVisitor<ConjugateGradient>())
         .def(IdVisitor());
   }
diff --git a/include/nanoeigenpy/solvers/least-squares-conjugate-gradient.hpp b/include/nanoeigenpy/solvers/least-squares-conjugate-gradient.hpp
@@ -26,8 +26,7 @@ struct LeastSquaresConjugateGradientVisitor
   }
 
   static void expose(nb::module_& m, const char* name) {
-    nb::class_<LeastSquaresConjugateGradient>(
-        m, name, nb::is_final())  // is_final good to replace bp::noncopyable ?
+    nb::class_<LeastSquaresConjugateGradient>(m, name)
         .def(IterativeSolverVisitor<LeastSquaresConjugateGradient>())
         .def(LeastSquaresConjugateGradientVisitor<
              LeastSquaresConjugateGradient>())

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,7 @@ struct ConjugateGradientVisitor`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`static void expose(nb::module_& m, const char* name) {`
`29`		`- nb::class_<ConjugateGradient>(`
`30`		`- m, name, nb::is_final()) // is_final good to replace bp::noncopyable ?`
	`29`	`+ nb::class_<ConjugateGradient>(m, name)`
`31`	`30`	`.def(ConjugateGradientVisitor<ConjugateGradient>())`
`32`	`31`	`.def(IdVisitor());`
`33`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,7 @@ struct LeastSquaresConjugateGradientVisitor`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`static void expose(nb::module_& m, const char* name) {`
`29`		`- nb::class_<LeastSquaresConjugateGradient>(`
`30`		`- m, name, nb::is_final()) // is_final good to replace bp::noncopyable ?`
	`29`	`+ nb::class_<LeastSquaresConjugateGradient>(m, name)`
`31`	`30`	`.def(IterativeSolverVisitor<LeastSquaresConjugateGradient>())`
`32`	`31`	`.def(LeastSquaresConjugateGradientVisitor<`
`33`	`32`	`LeastSquaresConjugateGradient>())`