Skip to content

Commit 7b0deb1

Browse files
committed
CI: Add typename in using RealScalar
1 parent 87f2e46 commit 7b0deb1

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

include/nanoeigenpy/geometry/hyperplane.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ template <typename Scalar>
2020
void exposeHyperplane(nb::module_ m, const char *name) {
2121
using namespace nb::literals;
2222
using Hyperplane = Eigen::Hyperplane<Scalar, Eigen::Dynamic>;
23-
using RealScalar = Eigen::NumTraits<Scalar>::Real;
23+
using RealScalar = typename Eigen::NumTraits<Scalar>::Real;
2424
using VectorType = Eigen::Matrix<Scalar, Eigen::Dynamic, 1>;
25-
using MatrixType = Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic, 1>;
2625
using Parameterized = Eigen::ParametrizedLine<Scalar, Eigen::Dynamic>;
2726

2827
if (check_registration_alias<Hyperplane>(m)) {

include/nanoeigenpy/geometry/jacobi-rotation.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
namespace nanoeigenpy {
99
namespace nb = nanobind;
10+
using namespace nb::literals;
1011

1112
template <typename Scalar>
1213
void exposeJacobiRotation(nb::module_ m, const char* name) {
13-
using namespace nb::literals;
1414
using JacobiRotation = Eigen::JacobiRotation<Scalar>;
15-
using RealScalar = Eigen::NumTraits<Scalar>::Real;
15+
using RealScalar = typename Eigen::NumTraits<Scalar>::Real;
1616

1717
if (check_registration_alias<JacobiRotation>(m)) {
1818
return;
@@ -58,7 +58,7 @@ void exposeJacobiRotation(nb::module_ m, const char* name) {
5858
.def(
5959
"makeGivens",
6060
[](JacobiRotation& self, const Scalar& p, const Scalar& q,
61-
Scalar* r = 0) { self.makeGivens(p, q, r); },
61+
Scalar* r) { self.makeGivens(p, q, r); },
6262
"p"_a, "q"_a, "r"_a)
6363

6464
.def(IdVisitor());

include/nanoeigenpy/geometry/parametrized-line.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ template <typename Scalar>
2020
void exposeParametrizedLine(nb::module_ m, const char *name) {
2121
using namespace nb::literals;
2222
using ParametrizedLine = Eigen::ParametrizedLine<Scalar, Eigen::Dynamic>;
23-
using RealScalar = Eigen::NumTraits<Scalar>::Real;
2423
using VectorType = Eigen::Matrix<Scalar, Eigen::Dynamic, 1>;
2524
using Hyperplane = Eigen::Hyperplane<Scalar, Eigen::Dynamic>;
2625

include/nanoeigenpy/solvers/incomplete-cholesky.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ template <typename _MatrixType>
1212
void exposeIncompleteCholesky(nb::module_ m, const char* name) {
1313
using MatrixType = _MatrixType;
1414
using Scalar = typename MatrixType::Scalar;
15-
using RealScalar = Eigen::NumTraits<Scalar>::Real;
15+
using RealScalar = typename Eigen::NumTraits<Scalar>::Real;
1616
using Solver = Eigen::IncompleteCholesky<Scalar>;
1717
using Factortype = Eigen::SparseMatrix<Scalar, Eigen::ColMajor>;
1818
using VectorRx = Eigen::Matrix<RealScalar, Eigen::Dynamic, 1>;

include/nanoeigenpy/solvers/incomplete-lut.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ template <typename _MatrixType>
1212
void exposeIncompleteLUT(nb::module_ m, const char* name) {
1313
using MatrixType = _MatrixType;
1414
using Scalar = typename MatrixType::Scalar;
15-
using RealScalar = Eigen::NumTraits<Scalar>::Real;
15+
using RealScalar = typename Eigen::NumTraits<Scalar>::Real;
1616
using Solver = Eigen::IncompleteLUT<Scalar>;
1717

1818
static constexpr int Options =

0 commit comments

Comments
 (0)