Skip to content

Commit 807901b

Browse files
committed
Do not use EigenBaseVisitor in SimplicialCholeskyVisitor -- simplicial cholesky solvers do not inherit from EigenBase!
1 parent 0ac788e commit 807901b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/nanoeigenpy/decompositions/sparse/SimplicialCholesky.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/// Copyright 2025 INRIA
22
#pragma once
33

4-
#include "nanoeigenpy/decompositions/base.hpp"
54
#include "nanoeigenpy/decompositions/sparse/SparseSolverBase.hpp"
65

76
#include <Eigen/SparseCholesky>
@@ -27,7 +26,6 @@ struct SimplicialCholeskyVisitor : nb::def_visitor<SimplicialCholeskyVisitor> {
2726
"This function is particularly useful when solving for several "
2827
"problems having the same structure.")
2928

30-
.def(EigenBaseVisitor())
3129
.def(SparseSolverBaseVisitor())
3230

3331
.def(
@@ -58,6 +56,8 @@ struct SimplicialCholeskyVisitor : nb::def_visitor<SimplicialCholeskyVisitor> {
5856
"which the symbolic decomposition has been performed.\n"
5957
"See also analyzePattern().")
6058

59+
.def("rows", &Solver::rows)
60+
.def("cols", &Solver::cols)
6161
.def("info", &Solver::info,
6262
"NumericalIssue if the input contains INF or NaN values or "
6363
"overflow occured. Returns Success otherwise.")

0 commit comments

Comments
 (0)