Removed ill coded adjoint and transpose in SparseLU

Author: Lucas-Haubert

include/nanoeigenpy/decompositions/sparse/sparse-lu.hpp

@@ -62,9 +62,6 @@ void exposeSparseLU(nb::module_ m, const char *name) {
   using Scalar = typename MatrixType::Scalar;
   using RealScalar = typename MatrixType::RealScalar;
   using StorageIndex = typename MatrixType::StorageIndex;
-  using SparseLUTransposeViewTrue = Eigen::SparseLUTransposeView<true, Solver>;
-  using SparseLUTransposeViewFalse =
-      Eigen::SparseLUTransposeView<false, Solver>;
   using SCMatrix = typename Solver::SCMatrix;
   using MappedSparseMatrix =
       typename Eigen::MappedSparseMatrix<Scalar, Eigen::ColMajor, StorageIndex>;
@@ -78,20 +75,6 @@ void exposeSparseLU(nb::module_ m, const char *name) {
   exposeMatrixL<SCMatrix>(m);
   exposeMatrixU<SCMatrix, MappedSparseMatrix>(m);
 
-  nb::class_<SparseLUTransposeViewFalse>(m, "SparseLUTransposeView")
-      .def(SparseSolverBaseVisitor())
-      .def("setIsInitialized", &SparseLUTransposeViewFalse::setIsInitialized)
-      .def("setSparseLU", &SparseLUTransposeViewFalse::setSparseLU)
-      .def("rows", &SparseLUTransposeViewFalse::rows)
-      .def("cols", &SparseLUTransposeViewFalse::cols);
-
-  nb::class_<SparseLUTransposeViewTrue>(m, "SparseLUAdjointView")
-      .def(SparseSolverBaseVisitor())
-      .def("setIsInitialized", &SparseLUTransposeViewTrue::setIsInitialized)
-      .def("setSparseLU", &SparseLUTransposeViewTrue::setSparseLU)
-      .def("rows", &SparseLUTransposeViewTrue::rows)
-      .def("cols", &SparseLUTransposeViewTrue::cols);
-
   nb::class_<Solver>(
       m, name,
       "Sparse supernodal LU factorization for general matrices.\n\n"
@@ -142,22 +125,6 @@ void exposeSparseLU(nb::module_ m, const char *name) {
            "matrix.\n\n"
            "The input matrix should be in column-major storage.")
 
-      .def(
-          "transpose",
-          [](Solver &self) -> SparseLUTransposeViewFalse {
-            auto view = self.transpose();
-            return view;
-          },
-          "Returns an expression of the transposed of the factored matrix.")
-
-      .def(
-          "adjoint",
-          [](Solver &self) -> SparseLUTransposeViewTrue {
-            auto view = self.adjoint();
-            return view;
-          },
-          "Returns an expression of the adjoint of the factored matrix.")
-
       .def(
           "matrixL", [](const Solver &self) -> LType { return self.matrixL(); },
           "Returns an expression of the matrix L.")

tests/test_sparse_lu.py

@@ -61,15 +61,3 @@
 x_reconstructed[P_cols_indices] = y
 
 assert nanoeigenpy.is_approx(x_reconstructed, x_true, 1e-6)
-
-splu_transpose = splu.transpose()
-splu_adjoint = splu.adjoint()
-
-x_true = rng.random(dim)
-b_transpose = A.T.dot(x_true)
-x_est = splu_transpose.solve(b_transpose)
-assert nanoeigenpy.is_approx(x_true, x_est)
-
-x_est_adj = splu_adjoint.solve(b_transpose)
-assert nanoeigenpy.is_approx(x_true, x_est_adj)
-assert nanoeigenpy.is_approx(x_est, x_est_adj)